You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/02/01 02:00:46 UTC
Review Request 65445: Added new protobuf field `launch_executor` in
RunTask(Group)Message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65445/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
Bugs: MESOS-1720
https://issues.apache.org/jira/browse/MESOS-1720
Repository: mesos
Description
-------
This boolean flag is used for the master to specify whether a
new executor should be launched for the task or taskGroup (with
the exception of command executor). This will let the master
to control executor creation on the agent.
Also updated the relevant message handlers and mock functions.
Diffs
-----
src/messages/messages.proto 0db44a24979cfdc748cd7fa3acd9e0346b14cfd3
src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5
src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4
src/tests/mock_slave.hpp 29ce7140501888d95d5f2d6c26b752ad276b484a
src/tests/mock_slave.cpp 8357edc7b3a35624c813eccb9ecca9d3b5dbe07c
src/tests/slave_tests.cpp f393a8433a984267adc4db307ef07fcbafd1e62f
Diff: https://reviews.apache.org/r/65445/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 65445: Added new protobuf field `launch_executor`
in RunTask(Group)Message.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65445/#review196610
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.hpp
Lines 149 (patched)
<https://reviews.apache.org/r/65445/#comment276300>
`s/runTaskMessageHandler/handleRunTaskMessage/`, so the name is consistent with `handleResourceProviderMessage`.
src/slave/slave.hpp
Lines 182 (patched)
<https://reviews.apache.org/r/65445/#comment276301>
`s/runTaskGroupMessageHandler/handleRunTaskGroupMessage/`
- Chun-Hung Hsiao
On Feb. 1, 2018, 2 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65445/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 2 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
>
>
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This boolean flag is used for the master to specify whether a
> new executor should be launched for the task or taskGroup (with
> the exception of command executor). This will let the master
> to control executor creation on the agent.
>
> Also updated the relevant message handlers and mock functions.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 0db44a24979cfdc748cd7fa3acd9e0346b14cfd3
> src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5
> src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4
> src/tests/mock_slave.hpp 29ce7140501888d95d5f2d6c26b752ad276b484a
> src/tests/mock_slave.cpp 8357edc7b3a35624c813eccb9ecca9d3b5dbe07c
> src/tests/slave_tests.cpp f393a8433a984267adc4db307ef07fcbafd1e62f
>
>
> Diff: https://reviews.apache.org/r/65445/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 65445: Added new protobuf field `launch_executor`
in RunTask(Group)Message.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65445/#review196924
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 5, 2018, 2:44 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65445/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 2:44 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
>
>
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This boolean flag is used for the master to specify whether a
> new executor should be launched for the task or taskGroup (with
> the exception of command executor). This will let the master
> to control executor creation on the agent.
>
> Also updated the relevant message handlers and mock functions.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 0db44a24979cfdc748cd7fa3acd9e0346b14cfd3
> src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5
> src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4
> src/tests/mock_slave.hpp 29ce7140501888d95d5f2d6c26b752ad276b484a
> src/tests/mock_slave.cpp 8357edc7b3a35624c813eccb9ecca9d3b5dbe07c
> src/tests/slave_tests.cpp f393a8433a984267adc4db307ef07fcbafd1e62f
>
>
> Diff: https://reviews.apache.org/r/65445/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 65445: Added new protobuf field `launch_executor`
in RunTask(Group)Message.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65445/
-----------------------------------------------------------
(Updated Feb. 4, 2018, 6:44 p.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
Changes
-------
Patch updated. Thanks for the comments.
Bugs: MESOS-1720
https://issues.apache.org/jira/browse/MESOS-1720
Repository: mesos
Description
-------
This boolean flag is used for the master to specify whether a
new executor should be launched for the task or taskGroup (with
the exception of command executor). This will let the master
to control executor creation on the agent.
Also updated the relevant message handlers and mock functions.
Diffs (updated)
-----
src/messages/messages.proto 0db44a24979cfdc748cd7fa3acd9e0346b14cfd3
src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5
src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4
src/tests/mock_slave.hpp 29ce7140501888d95d5f2d6c26b752ad276b484a
src/tests/mock_slave.cpp 8357edc7b3a35624c813eccb9ecca9d3b5dbe07c
src/tests/slave_tests.cpp f393a8433a984267adc4db307ef07fcbafd1e62f
Diff: https://reviews.apache.org/r/65445/diff/2/
Changes: https://reviews.apache.org/r/65445/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 65445: Added new protobuf field `launch_executor`
in RunTask(Group)Message.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65445/#review196661
-----------------------------------------------------------
src/messages/messages.proto
Lines 333 (patched)
<https://reviews.apache.org/r/65445/#comment276398>
s/field/field value/
src/messages/messages.proto
Lines 368 (patched)
<https://reviews.apache.org/r/65445/#comment276399>
s/field/field value/
src/slave/slave.hpp
Lines 149 (patched)
<https://reviews.apache.org/r/65445/#comment276404>
There are other handlers installed that do not use the `handle` prefix, eg., `KillTaskMessage`?
src/slave/slave.hpp
Lines 161 (patched)
<https://reviews.apache.org/r/65445/#comment276401>
s/toLaunchExecutor/launchExecutor/
src/slave/slave.hpp
Lines 193 (patched)
<https://reviews.apache.org/r/65445/#comment276402>
ditto.
src/tests/mock_slave.hpp
Lines 111 (patched)
<https://reviews.apache.org/r/65445/#comment276405>
s/toLaunchExecutor/launchExecutor/
here and below.
- Vinod Kone
On Feb. 1, 2018, 2 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65445/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 2 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
>
>
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This boolean flag is used for the master to specify whether a
> new executor should be launched for the task or taskGroup (with
> the exception of command executor). This will let the master
> to control executor creation on the agent.
>
> Also updated the relevant message handlers and mock functions.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 0db44a24979cfdc748cd7fa3acd9e0346b14cfd3
> src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5
> src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4
> src/tests/mock_slave.hpp 29ce7140501888d95d5f2d6c26b752ad276b484a
> src/tests/mock_slave.cpp 8357edc7b3a35624c813eccb9ecca9d3b5dbe07c
> src/tests/slave_tests.cpp f393a8433a984267adc4db307ef07fcbafd1e62f
>
>
> Diff: https://reviews.apache.org/r/65445/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 65445: Added new protobuf field `launch_executor`
in RunTask(Group)Message.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65445/#review196613
-----------------------------------------------------------
PASS: Mesos patch 65445 was successfully built and tested.
Reviews applied: `['65445']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65445
- Mesos Reviewbot Windows
On Feb. 1, 2018, 2 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65445/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 2 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
>
>
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This boolean flag is used for the master to specify whether a
> new executor should be launched for the task or taskGroup (with
> the exception of command executor). This will let the master
> to control executor creation on the agent.
>
> Also updated the relevant message handlers and mock functions.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 0db44a24979cfdc748cd7fa3acd9e0346b14cfd3
> src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5
> src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4
> src/tests/mock_slave.hpp 29ce7140501888d95d5f2d6c26b752ad276b484a
> src/tests/mock_slave.cpp 8357edc7b3a35624c813eccb9ecca9d3b5dbe07c
> src/tests/slave_tests.cpp f393a8433a984267adc4db307ef07fcbafd1e62f
>
>
> Diff: https://reviews.apache.org/r/65445/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>