You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "vogievetsky (via GitHub)" <gi...@apache.org> on 2023/07/07 03:45:35 UTC
[PR] Web console: catchup to all the backend changes (druid)
vogievetsky opened a new pull request, #14540:
URL: https://github.com/apache/druid/pull/14540
This PR catches the console up to all the backend changes for Druid 27
Specifically:
- https://github.com/apache/druid/pull/14512
- https://github.com/apache/druid/pull/14432
- https://github.com/apache/druid/pull/14416
- https://github.com/apache/druid/pull/14403
- https://github.com/apache/druid/pull/14307
- https://github.com/apache/druid/pull/14004
In addition this PR also:
- Adds a UI for dynamic compaction
<img width="520" alt="image" src="https://github.com/apache/druid/assets/177816/a75064ab-914a-4de1-af22-7f5c957efb16">
- Allows formulas and decimals to be used in numeric inputs
<img width="492" alt="image" src="https://github.com/apache/druid/assets/177816/542a82bf-bf91-4f8e-8d88-ee2c2e2eecdb">
- Fixes the auto refresh so it does not overwhelm the server
- Fixes the JSX import to be explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Web console: catchup to all the backend changes (druid)
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on code in PR #14540:
URL: https://github.com/apache/druid/pull/14540#discussion_r1263167124
##########
web-console/src/views/home-view/segments-card/segments-card.tsx:
##########
@@ -60,17 +66,22 @@ FROM sys.segments`,
);
return {
- total: availableSegmentNum + unavailableSegmentNum,
+ active: availableSegmentNum + unavailableSegmentNum,
+ cached_on_historical: availableSegmentNum, // This is not correct
Review Comment:
?
##########
web-console/src/utils/druid-query.spec.ts:
##########
@@ -16,41 +16,38 @@
* limitations under the License.
*/
-import { sane } from 'druid-query-toolkit';
+import { sane } from '@druid-toolkit/query';
import { DruidError, getDruidErrorMessage } from './druid-query';
describe('DruidQuery', () => {
describe('DruidError.parsePosition', () => {
- it('works for single error 1', () => {
- const message = `Encountered "COUNT" at line 2, column 12. Was expecting one of: <EOF> "AS" ... "EXCEPT" ... "FETCH" ... "FROM" ... "INTERSECT" ... "LIMIT" ...`;
-
- expect(DruidError.parsePosition(message)).toEqual({
- match: 'at line 2, column 12',
- row: 1,
- column: 11,
- });
- });
-
- it('works for single error 2', () => {
- const message = `org.apache.calcite.runtime.CalciteContextException: At line 2, column 20: Unknown identifier '*'`;
-
- expect(DruidError.parsePosition(message)).toEqual({
- match: 'At line 2, column 20',
- row: 1,
- column: 19,
- });
- });
+ // it('works for single error 1', () => {
Review Comment:
why commented out?
##########
web-console/src/utils/druid-query.ts:
##########
@@ -27,9 +27,27 @@ import type { RowColumn } from './query-cursor';
const CANCELED_MESSAGE = 'Query canceled by user.';
-export interface DruidErrorResponse {
+export type ErrorResponsePersona = 'USER' | 'ADMIN' | 'OPERATOR' | 'DEVELOPER';
+export type ErrorResponseCategory =
+ | 'DEFENSIVE'
+ | 'INVALID_INPUT'
+ | 'UNAUTHORIZED'
Review Comment:
there is also `FORBIDDEN` (403 status), is it left out on purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Web console: catchup to all the backend changes (druid)
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #14540:
URL: https://github.com/apache/druid/pull/14540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Web console: catchup to all the backend changes (druid)
Posted by "vogievetsky (via GitHub)" <gi...@apache.org>.
vogievetsky commented on code in PR #14540:
URL: https://github.com/apache/druid/pull/14540#discussion_r1263698719
##########
web-console/src/utils/druid-query.ts:
##########
@@ -27,9 +27,27 @@ import type { RowColumn } from './query-cursor';
const CANCELED_MESSAGE = 'Query canceled by user.';
-export interface DruidErrorResponse {
+export type ErrorResponsePersona = 'USER' | 'ADMIN' | 'OPERATOR' | 'DEVELOPER';
+export type ErrorResponseCategory =
+ | 'DEFENSIVE'
+ | 'INVALID_INPUT'
+ | 'UNAUTHORIZED'
Review Comment:
Oh, I took that list from here https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/error/ErrorResponse.java#L43 but I guess I should have gone to the definition instead. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org