You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@oozie.apache.org by bowen zhang <bo...@yahoo.com> on 2013/12/05 23:29:18 UTC

verifySlaElements in submitXCommand

Hi,
I have a question for people from yahoo who did the SLA work. In verifySlaElements function in submitXCommand, within the "for" loop, shouldn't we call XmlUtils.getSLAElement(action) instead of XmlUtils.getSLAElement(eWfJob) to extract the sla element embedded inside the action tag? If this is indeed a bug, I am going to file one.
Bowen

Re: verifySlaElements in submitXCommand

Posted by Rohini Palaniswamy <ro...@gmail.com>.

Yes. You are right. The validation section for actions in verifySlaElements
is verifying the job one again and again in loop which is wrong. But when
writing to database it is fine.

Regards,
Rohini

On Thu, Dec 5, 2013 at 2:29 PM, bowen zhang <bo...@yahoo.com> wrote:

> Hi,
> I have a question for people from yahoo who did the SLA work. In
> verifySlaElements function in submitXCommand, within the "for" loop,
> shouldn't we call XmlUtils.getSLAElement(action) instead of
> XmlUtils.getSLAElement(eWfJob) to extract the sla element embedded inside
> the action tag? If this is indeed a bug, I am going to file one.
> Bowen

Re: verifySlaElements in submitXCommand

Posted by bowen zhang <bo...@yahoo.com>.

Can anyone review https://issues.apache.org/jira/browse/OOZIE-1635?
Bowen

On Thursday, December 5, 2013 2:51 PM, Mona Chitnis <ch...@yahoo-inc.com> wrote:

Good catch! I quickly verified that changing to
XmlUtils.getSLAElement(action) does not cause any regression in a few
related unit tests.

Thanks,

Mona

On 12/5/13 2:29 PM, "bowen zhang" <bo...@yahoo.com> wrote:

>Hi,
>I have a question for people from yahoo who did the SLA work. In
>verifySlaElements function in submitXCommand, within the "for" loop,
>shouldn't we call XmlUtils.getSLAElement(action) instead of
>XmlUtils.getSLAElement(eWfJob) to extract the sla element embedded inside
>the action tag? If this is indeed a bug, I am going to file one.
>Bowen

Re: verifySlaElements in submitXCommand

Posted by Mona Chitnis <ch...@yahoo-inc.com>.

Good catch! I quickly verified that changing to
XmlUtils.getSLAElement(action) does not cause any regression in a few
related unit tests.

Thanks,

Mona

On 12/5/13 2:29 PM, "bowen zhang" <bo...@yahoo.com> wrote:

>Hi,
>I have a question for people from yahoo who did the SLA work. In
>verifySlaElements function in submitXCommand, within the "for" loop,
>shouldn't we call XmlUtils.getSLAElement(action) instead of
>XmlUtils.getSLAElement(eWfJob) to extract the sla element embedded inside
>the action tag? If this is indeed a bug, I am going to file one.
>Bowen