You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/28 18:25:00 UTC
[GitHub] [arrow] pitrou opened a new pull request #10609: ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file
pitrou opened a new pull request #10609:
URL: https://github.com/apache/arrow/pull/10609
Some Python versions have a bug where `signal.getsignal` creates a reference cycle holding execution frames alive (https://bugs.python.org/issue42248).
This would cause excessive lifetimes of the PyArrow table returned by `read_csv`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #10609: ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #10609:
URL: https://github.com/apache/arrow/pull/10609#discussion_r660094335
##########
File path: python/pyarrow/error.pxi
##########
@@ -24,6 +24,9 @@ from contextlib import contextmanager
import os
import signal
import threading
+import weakref
Review comment:
Do you need weakref here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #10609: ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #10609:
URL: https://github.com/apache/arrow/pull/10609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #10609: ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #10609:
URL: https://github.com/apache/arrow/pull/10609#discussion_r660591800
##########
File path: python/pyarrow/error.pxi
##########
@@ -24,6 +24,9 @@ from contextlib import contextmanager
import os
import signal
import threading
+import weakref
Review comment:
No, it's just a remnant from a failed attempt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #10609: ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #10609:
URL: https://github.com/apache/arrow/pull/10609#discussion_r660094335
##########
File path: python/pyarrow/error.pxi
##########
@@ -24,6 +24,9 @@ from contextlib import contextmanager
import os
import signal
import threading
+import weakref
Review comment:
Do you need weakref here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #10609: ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #10609:
URL: https://github.com/apache/arrow/pull/10609#discussion_r660591800
##########
File path: python/pyarrow/error.pxi
##########
@@ -24,6 +24,9 @@ from contextlib import contextmanager
import os
import signal
import threading
+import weakref
Review comment:
No, it's just a remnant from a failed attempt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10609: ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10609:
URL: https://github.com/apache/arrow/pull/10609#issuecomment-869916158
https://issues.apache.org/jira/browse/ARROW-13187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10609: ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10609:
URL: https://github.com/apache/arrow/pull/10609#issuecomment-869916060
cc @westonpace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10609: ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10609:
URL: https://github.com/apache/arrow/pull/10609#issuecomment-869916060
cc @westonpace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10609: ARROW-13187: [Python] Avoid creating reference cycle when reading CSV file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10609:
URL: https://github.com/apache/arrow/pull/10609#issuecomment-869916158
https://issues.apache.org/jira/browse/ARROW-13187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org