[GitHub] fmaximus commented on a change in pull request #1439: Changed Void Methods to void

[GitBox <gi...@apache.org>]

fmaximus commented on a change in pull request #1439: Changed Void Methods to void
URL: https://github.com/apache/cloudstack/pull/1439#discussion_r147167607
 
 

 ##########
 File path: engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
 ##########
 @@ -687,7 +681,7 @@ public Void deleteTemplateCallback(AsyncCallbackDispatcher<TemplateServiceImpl,
         return future;
     }
 
-    protected Void syncTemplateCallBack(AsyncCallbackDispatcher<TemplateServiceImpl, CopyCommandResult> callback, TemplateOpContext<TemplateApiResult> context) {
+    protected void syncTemplateCallBack(AsyncCallbackDispatcher<TemplateServiceImpl, CopyCommandResult> callback, TemplateOpContext<TemplateApiResult> context) {
 
 Review comment:
   Changing this creates compilation errors in caller.setCallback(...) in deleteTemplateAsync.
   So the reason that Void is used, is that the response is passed to a method expecting an Object as parameter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services