You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "wg1026688210 (via GitHub)" <gi...@apache.org> on 2026/05/08 07:27:04 UTC
[PR] [CALCITE-7353] introduce Milvus adapter with scan and convention support [calcite]
wg1026688210 opened a new pull request, #4925:
URL: https://github.com/apache/calcite/pull/4925
Add the foundational Milvus adapter module to Apache Calcite:
- MilvusRel convention interface and MilvusTableScan operator
- MilvusSchema / MilvusSchemaFactory for schema integration
- MilvusTranslatableTable with scan() for collection reads
- MilvusToEnumerableConverter and converter rule for code generation
- MilvusQueryEnumerator with pagination via MilvusRowIterator
- MilvusProjectExpression for projection handling
- Test infrastructure: E2E base, JUnit 5 extension, Testcontainers
This is the minimal skeleton; Filter/Project/VectorSearch rules are intentionally omitted for subsequent PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7353] introduce Milvus adapter with scan and convention support [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4925:
URL: https://github.com/apache/calcite/pull/4925#issuecomment-4539889006
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4925) **Quality Gate passed**
Issues
 [16 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4925&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4925&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4925&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4925&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4925&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4925)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7353] introduce Milvus adapter with scan and convention support [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #4925:
URL: https://github.com/apache/calcite/pull/4925#issuecomment-4544786887
Thank you for the contribution @wg1026688210 ! Although I don't know much about Milvus, I think this adapter is very valuable. As @zabetak stated in CALCITE-6908, the test coverage of the milvus adaptor should ideally reach 80%. I suggest including test cases along with the feature descriptions and adding the test cases mentioned in the descriptions to the code. This will make it easier for reviewers to review the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7353] introduce Milvus adapter with scan and convention support [calcite]
Posted by "wg1026688210 (via GitHub)" <gi...@apache.org>.
wg1026688210 commented on PR #4925:
URL: https://github.com/apache/calcite/pull/4925#issuecomment-4543012364
> > I was expecting to see some kind of README for such a large project, explaining what Milvus is, how it relates to Calcite, and how people can use the adapter. Or perhaps there's some other place for the adapters documentation? But I don't see any.
>
> Thank you for the contribution @wg1026688210 ! As @mihaibudiu mentioned, we can first add some background and value information in Jira. Currently, we support many adapters, and the universality and uniqueness of adapters are important reference indicators for introducing adapters.
Hi~ @xuzifu666 @mihaibudiu Thanks for your feedback. There have been some discussions in this [Jira](https://issues.apache.org/jira/browse/CALCITE-7353).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7353] introduce Milvus adapter with scan and convention support [calcite]
Posted by "wg1026688210 (via GitHub)" <gi...@apache.org>.
wg1026688210 commented on PR #4925:
URL: https://github.com/apache/calcite/pull/4925#issuecomment-4540172546
@cjj2010 @xuzifu666 @mihaibudiu cc ,the pr is ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7353] introduce Milvus adapter with scan and convention support [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #4925:
URL: https://github.com/apache/calcite/pull/4925#issuecomment-4541249921
> I was expecting to see some kind of README for such a large project, explaining what Milvus is, how it relates to Calcite, and how people can use the adapter. Or perhaps there's some other place for the adapters documentation? But I don't see any.
Thank you for the contribution @wg1026688210 ! As @mihaibudiu mentioned, we can first add some background and value information in Jira. Currently, we support many adapters, and the universality and uniqueness of adapters are important reference indicators for introducing adapters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7353] introduce Milvus adapter with scan and convention support [calcite]
Posted by "cjj2010 (via GitHub)" <gi...@apache.org>.
cjj2010 commented on PR #4925:
URL: https://github.com/apache/calcite/pull/4925#issuecomment-4412053595
CI error:
"Caused by: java.lang.IllegalStateException: Could not find a valid Docker environment. Please see logs and check configuration"
It seems to be related to the Docker environment. Alternatively, you can check how the Redis adapter builds the Docker environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7353] introduce Milvus adapter with scan and convention support [calcite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4925:
URL: https://github.com/apache/calcite/pull/4925#issuecomment-4850412677
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7353] introduce Milvus adapter with scan and convention support [calcite]
Posted by "wg1026688210 (via GitHub)" <gi...@apache.org>.
wg1026688210 commented on PR #4925:
URL: https://github.com/apache/calcite/pull/4925#issuecomment-4542994722
> > I was expecting to see some kind of README for such a large project, explaining what Milvus is, how it relates to Calcite, and how people can use the adapter. Or perhaps there's some other place for the adapters documentation? But I don't see any.
>
> Thank you for the contribution @wg1026688210 ! As @mihaibudiu mentioned, we can first add some background and value information in Jira. Currently, we support many adapters, and the universality and uniqueness of adapters are important reference indicators for introducing adapters.
@mihaibudiu @xuzifu666 思考已完成
Hi~ Thanks for your feedback. There have been some discussions in this [Jira](https://github.com/apache/calcite/pull/4925#issuecomment-4541249921)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org