You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/11/01 17:57:00 UTC
[jira] [Commented] (CASSANDRASC-80) HealthCheckPeriodicTask execute never completes the promise when instances are empty
[ https://issues.apache.org/jira/browse/CASSANDRASC-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781847#comment-17781847 ]
ASF subversion and git services commented on CASSANDRASC-80:
------------------------------------------------------------
Commit 36d48b209c84470930d5ce3d4f4ab1c406dae60e in cassandra-sidecar's branch refs/heads/trunk from Francisco Guerrero
[ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=36d48b2 ]
CASSANDRASC-80: HealthCheckPeriodicTask execute never completes the promise when instances are empty
When the HealthCheckPeriodicTask executes, and the instances are null or empty, the promise never completes.
This prevents subsequent scheduled health checks to take place because the PeriodicTaskExecutor will only
schedule the new task only if no other tasks are active. This makes the HealthCheckPeriodicTask to never
perform health checks when this condition is encountered.
In this commit, we fix the issue by completing the promise when this condition is encountered.
Patch by Francisco Guerrero; Reviewed by Dinesh Joshi, Yifan Cai for CASSANDRASC-80
> HealthCheckPeriodicTask execute never completes the promise when instances are empty
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRASC-80
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-80
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Rest API
> Reporter: Francisco Guerrero
> Assignee: Francisco Guerrero
> Priority: Normal
> Labels: pull-request-available
>
> When the {{HealthCheckPeriodicTask}} executes, and the instances are {{null}} or empty, the promise never completes. This prevents subsequent scheduled health checks to take place because the {{PeriodicTaskExecutor}} will only schedule the new task only if no other tasks are active. This makes the HealthCheckPeriodicTask to never perform health checks when this condition is encountered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org