You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/01/20 19:19:51 UTC
[kudu-CR] [docs] add info on READ YOUR WRITES scan mode
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18164
Change subject: [docs] add info on READ_YOUR_WRITES scan mode
......................................................................
[docs] add info on READ_YOUR_WRITES scan mode
Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
---
M docs/transaction_semantics.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/18164/1
--
To view, visit http://gerrit.cloudera.org:8080/18164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
Gerrit-Change-Number: 18164
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] add info on READ YOUR WRITES scan mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18164 )
Change subject: [docs] add info on READ_YOUR_WRITES scan mode
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
Gerrit-Change-Number: 18164
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Jan 2022 05:01:52 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] add info on READ YOUR WRITES scan mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18164 )
Change subject: [docs] add info on READ_YOUR_WRITES scan mode
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18164/2/docs/transaction_semantics.adoc
File docs/transaction_semantics.adoc:
http://gerrit.cloudera.org:8080/#/c/18164/2/docs/transaction_semantics.adoc@246
PS2, Line 246: the timestamp which is higher than the timestamp provided by the client
: but lower than the server's oldest in-flight write operation, i.e.
: `max(client_propagated_timestamp + 1, server_clean_timestamp)`.
> Maybe:
Done
--
To view, visit http://gerrit.cloudera.org:8080/18164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
Gerrit-Change-Number: 18164
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Jan 2022 02:08:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] add info on READ YOUR WRITES scan mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18164 )
Change subject: [docs] add info on READ_YOUR_WRITES scan mode
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18164/1/docs/transaction_semantics.adoc
File docs/transaction_semantics.adoc:
http://gerrit.cloudera.org:8080/#/c/18164/1/docs/transaction_semantics.adoc@244
PS1, Line 244: When issuing a scan request in this read mode,
: a Kudu client automatically chooses a timestamp
> Maybe we should reword this to mention that the tablet servers are the ones
Indeed, that's the way it does so -- sounds better then the vague and a bit misleading notion of the client automatically selecting appropriate timestamp for the scan. Done.
http://gerrit.cloudera.org:8080/#/c/18164/1/docs/transaction_semantics.adoc@246
PS1, Line 246: but lower
> Isn't it equal to or higher than the clean time, given we take max(propagat
Done
--
To view, visit http://gerrit.cloudera.org:8080/18164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
Gerrit-Change-Number: 18164
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Jan 2022 20:49:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] add info on READ YOUR WRITES scan mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18164 )
Change subject: [docs] add info on READ_YOUR_WRITES scan mode
......................................................................
[docs] add info on READ_YOUR_WRITES scan mode
Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
Reviewed-on: http://gerrit.cloudera.org:8080/18164
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docs/transaction_semantics.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
Gerrit-Change-Number: 18164
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [docs] add info on READ YOUR WRITES scan mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18164 )
Change subject: [docs] add info on READ_YOUR_WRITES scan mode
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18164/2/docs/transaction_semantics.adoc
File docs/transaction_semantics.adoc:
http://gerrit.cloudera.org:8080/#/c/18164/2/docs/transaction_semantics.adoc@246
PS2, Line 246: the timestamp which is higher than the timestamp provided by the client
: but lower than the server's oldest in-flight write operation, i.e.
: `max(client_propagated_timestamp + 1, server_clean_timestamp)`.
Maybe:
"the server selects a timestamp higher than the timestamp provided by the client, that is also guaranteed to have all write operations prior already committed and applied to the data."
--
To view, visit http://gerrit.cloudera.org:8080/18164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
Gerrit-Change-Number: 18164
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Jan 2022 01:07:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] add info on READ YOUR WRITES scan mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18164 )
Change subject: [docs] add info on READ_YOUR_WRITES scan mode
......................................................................
Patch Set 1:
(2 comments)
Thanks for updating these docs!
http://gerrit.cloudera.org:8080/#/c/18164/1/docs/transaction_semantics.adoc
File docs/transaction_semantics.adoc:
http://gerrit.cloudera.org:8080/#/c/18164/1/docs/transaction_semantics.adoc@244
PS1, Line 244: When issuing a scan request in this read mode,
: a Kudu client automatically chooses a timestamp
Maybe we should reword this to mention that the tablet servers are the ones picking the timestamps?
http://gerrit.cloudera.org:8080/#/c/18164/1/docs/transaction_semantics.adoc@246
PS1, Line 246: but lower
Isn't it equal to or higher than the clean time, given we take max(propagated timestamp + 1, clean time)?
--
To view, visit http://gerrit.cloudera.org:8080/18164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
Gerrit-Change-Number: 18164
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Jan 2022 20:20:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] add info on READ YOUR WRITES scan mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18164
to look at the new patch set (#2).
Change subject: [docs] add info on READ_YOUR_WRITES scan mode
......................................................................
[docs] add info on READ_YOUR_WRITES scan mode
Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
---
M docs/transaction_semantics.adoc
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/18164/2
--
To view, visit http://gerrit.cloudera.org:8080/18164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
Gerrit-Change-Number: 18164
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [docs] add info on READ YOUR WRITES scan mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18164
to look at the new patch set (#3).
Change subject: [docs] add info on READ_YOUR_WRITES scan mode
......................................................................
[docs] add info on READ_YOUR_WRITES scan mode
Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
---
M docs/transaction_semantics.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/18164/3
--
To view, visit http://gerrit.cloudera.org:8080/18164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idccc6557d3f7dfc5640f932e460cbf7242044b51
Gerrit-Change-Number: 18164
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>