You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/02/01 07:17:42 UTC

[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #366: [YUNIKORN-1065] panic on node update

wilfred-s commented on pull request #366:
URL: https://github.com/apache/incubator-yunikorn-core/pull/366#issuecomment-1026541159


   The unit test failure is caused by my change. The call to `metrics.Reset()` in the health tests does not work It is an empty function. The tests I added trigger a metrics update and thus cause the health tests to fail.
   Implementing a proper rest of all metrics that can be reset.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org