[GitHub] matthiasblaesing edited a comment on issue #572: java.source.base: Fix for Java 11, update args, swap import

[GitBox <gi...@apache.org>]

matthiasblaesing edited a comment on issue #572: java.source.base: Fix for Java 11, update args, swap import
URL: https://github.com/apache/incubator-netbeans/pull/572#issuecomment-414147877
 
 
   You want to change the policy of netbeans, that can't be done with a small PR. You have an opinion and I respect that, but at this point you have yet to prove, that you are willing to work on the project.
   
   Your change breaks building on JDK 8 (at least you said so), but you also did not do the work necessary to make the whole project to build on JDK 11. So after your changeset is applied the project is not buildable anymore. That won't fly.
   
   I gave my reasoning, I offered pointers what could be done, others gave points what could be done. I'll lock the conversation here, so that if interest is there, it is moved to the mailinglist.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists