You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/14 14:17:54 UTC

[GitHub] [hadoop-ozone] fapifta opened a new pull request #818: HDDS-3386. Remove unnecessary transitive hadoop-common dependencies on server side (addendum).

fapifta opened a new pull request #818: HDDS-3386. Remove unnecessary transitive hadoop-common dependencies on server side (addendum).
URL: https://github.com/apache/hadoop-ozone/pull/818
 
 
   ## What changes were proposed in this pull request?
   In HDDS-3353 we have created two new modules to manage the hadoop-common dependency and excludes related to it in a common place.
   hadoop-hdds-dependency-test, and hadoop-hdds-dependency-server, similarly we had hadoop-hdds-dependency-client before.
   
   The following modules still depend on hadoop-common for tests instead of the new test dependency:
   hadoop-hdds/client
   hadoop-hdds/container-service
   hadoop-ozone/common
   hadoop-ozone/fault-injection-test/mini-chaos-tests
   hadoop-ozone/insight
   hadoop-ozone/integration-test
   hadoop-ozone/tools
   
   In hadoop-dependency-client, we exclude named curator packages, similar to the new modules we should instead exclude all curator packages.
   
   In TestVolumeSetDiskChecks.java we still have an accidental shaded import from curator: import org.apache.curator.shaded.com.google.common.collect.ImmutableSet;
   
   The PR is proposing to fix these.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-3386
   
   ## How was this patch tested?
   
   As a result of mvn clean install -DskipTests the build was successful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai merged pull request #818: HDDS-3386. Remove unnecessary transitive hadoop-common dependencies on server side (addendum).

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #818: HDDS-3386. Remove unnecessary transitive hadoop-common dependencies on server side (addendum).
URL: https://github.com/apache/hadoop-ozone/pull/818
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on issue #818: HDDS-3386. Remove unnecessary transitive hadoop-common dependencies on server side (addendum).

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #818: HDDS-3386. Remove unnecessary transitive hadoop-common dependencies on server side (addendum).
URL: https://github.com/apache/hadoop-ozone/pull/818#issuecomment-614650436
 
 
   Thanks @fapifta for the contribution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on issue #818: HDDS-3386. Remove unnecessary transitive hadoop-common dependencies on server side (addendum).

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #818: HDDS-3386. Remove unnecessary transitive hadoop-common dependencies on server side (addendum).
URL: https://github.com/apache/hadoop-ozone/pull/818#issuecomment-614661190
 
 
   Sorry, I should have triggered CI here, since unfortunately my PR was merged first, introducing a duplicate import (checkstyle violation) without merge conflict...  Fixed in follow-up commit 17456bc75bc56cea4f02a7570c0a2a2f535aada0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org