You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/27 12:45:45 UTC
[GitHub] [cloudstack] JoaoJandre opened a new pull request, #6771: Return object name in the listHypervisorCapabilities API
JoaoJandre opened a new pull request, #6771:
URL: https://github.com/apache/cloudstack/pull/6771
### Description
The `hypervisorCapabilitiesResponse` does not set an object name, returning a null object name instead. This PR adds an object name to the response.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
This was tested in a local lab, by calling the API via CloudMonkey and checking the object name value.
Before:
```
{
"null": {
"hypervisor": "VMware",
"hypervisorversion": "5.0",
"id": "11",
"maxdatavolumeslimit": 12,
"maxguestslimit": 127,
"maxhostspercluster": 31,
"securitygroupenabled": true,
"storagemotionenabled": true,
"vmsnapshotenabled": false
}
}
```
After:
```
{
"hypervisorcapabilities": {
"hypervisor": "VMware",
"hypervisorversion": "5.0",
"id": "11",
"maxdatavolumeslimit": 12,
"maxguestslimit": 127,
"maxhostspercluster": 31,
"securitygroupenabled": true,
"storagemotionenabled": true,
"vmsnapshotenabled": false
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1261782593
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1272241302
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1272241401
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1261917858
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1261783502
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1259537499
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6771?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6771](https://codecov.io/gh/apache/cloudstack/pull/6771?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f00b2a3) into [main](https://codecov.io/gh/apache/cloudstack/commit/8ab8fdc1db4fed4d906c69618980fda9ef710e6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ab8fdc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #6771 +/- ##
============================================
- Coverage 10.53% 10.52% -0.01%
+ Complexity 6786 6784 -2
============================================
Files 2464 2464
Lines 243988 243988
Branches 38185 38185
============================================
- Hits 25699 25690 -9
- Misses 215054 215065 +11
+ Partials 3235 3233 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6771?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (-15.39%)` | :arrow_down: |
| [...cloudstack/network/contrail/model/ModelObject.java](https://codecov.io/gh/apache/cloudstack/pull/6771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdC5qYXZh) | `29.16% <0.00%> (-4.17%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1262733558
<b>Trillian test result (tid-5044)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40260 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6771-t5044-kvm-centos7.zip
Smoke tests completed. 98 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.62 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
test_01_secure_vm_migration | `Error` | 164.72 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 298.38 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 143.83 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.77 | test_vm_life_cycle.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 33.97 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 101.57 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 42.11 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 40.23 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 129.62 | test_kubernetes_clusters.py
test_02_list_snapshots_with_removed_data_store | `Error` | 8.60 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 8.60 | test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.74 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1259530180
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6771)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6771&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6771&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6771&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6771&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6771&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6771&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6771&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6771&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6771&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6771&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6771&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6771&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6771&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6771&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6771&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6771&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1261840180
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1261918293
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6771: Return object name in the listHypervisorCapabilities API
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6771:
URL: https://github.com/apache/cloudstack/pull/6771#issuecomment-1272387745
<b>Trillian test result (tid-5083)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47163 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6771-t5083-kvm-centos7.zip
Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 3642.28 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 829.12 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org