You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/05 08:21:46 UTC

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4959: Add schemaFile as option in AddTableCommand

fx19880617 opened a new pull request #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959
 
 
   So it's possible to create a table in one command.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#issuecomment-570891639
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=h1) Report
   > Merging [#4959](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9edad92cd19e3e9cd4089a62524405b6e9c9b19a?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4959/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4959      +/-   ##
   ============================================
   + Coverage     57.63%   57.64%   +0.01%     
     Complexity       12       12              
   ============================================
     Files          1143     1143              
     Lines         61315    61324       +9     
     Branches       9055     9056       +1     
   ============================================
   + Hits          35338    35353      +15     
   + Misses        23346    23343       -3     
   + Partials       2631     2628       -3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...c/main/java/org/apache/pinot/tools/Quickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1F1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/pinot/tools/HybridQuickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL0h5YnJpZFF1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ava/org/apache/pinot/tools/RealtimeQuickStart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1JlYWx0aW1lUXVpY2tTdGFydC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/pinot/tools/query/comparison/ClusterStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vQ2x1c3RlclN0YXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...pinot/tools/admin/command/GenerateDataCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvR2VuZXJhdGVEYXRhQ29tbWFuZC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...che/pinot/tools/admin/command/AddTableCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQWRkVGFibGVDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...he/pinot/tools/admin/command/QuickstartRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvUXVpY2tzdGFydFJ1bm5lci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
   | [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `46.03% <0%> (-14.29%)` | `0% <0%> (ø)` | |
   | ... and [18 more](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=footer). Last update [9edad92...bcdd16c](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#discussion_r363109550
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java
 ##########
 @@ -102,33 +112,51 @@ public AddTableCommand setExecute(boolean exec) {
     return this;
   }
 
-  public boolean execute(JsonNode node)
+  public boolean sendTableCreationRequest(JsonNode node)
       throws IOException {
-    if (_controllerHost == null) {
-      _controllerHost = NetUtil.getHostAddress();
-    }
-    _controllerAddress = "http://" + _controllerHost + ":" + _controllerPort;
+    String res = AbstractBaseAdminCommand
+        .sendPostRequest(ControllerRequestURLBuilder.baseUrl(_controllerAddress).forTableCreate(), node.toString());
+    LOGGER.info(res);
+    return res.contains("succesfully added");
+  }
 
+  @Override
+  public boolean execute()
+      throws Exception {
     if (!_exec) {
       LOGGER.warn("Dry Running Command: " + toString());
       LOGGER.warn("Use the -exec option to actually execute the command.");
       return true;
     }
 
-    LOGGER.info("Executing command: " + toString());
-    String res = AbstractBaseAdminCommand
-        .sendPostRequest(ControllerRequestURLBuilder.baseUrl(_controllerAddress).forTableCreate(), node.toString());
+    if (_controllerHost == null) {
+      _controllerHost = NetUtil.getHostAddress();
+    }
+    _controllerAddress = "http://" + _controllerHost + ":" + _controllerPort;
 
-    LOGGER.info(res);
-    if (res.contains("succesfully added")) {
-      return true;
+    LOGGER.info("Executing command: " + toString());
+    // Backward compatible
+    if (_schemaFile != null) {
+      File schemaFile = new File(_schemaFile);
+      if (!schemaFile.exists()) {
+        throw new FileNotFoundException("schema file does not exist: " + _schemaFile);
 
 Review comment:
   ```suggestion
           throw new FileNotFoundException("Schema file does not exist: " + _schemaFile);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#discussion_r363488701
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java
 ##########
 @@ -102,33 +111,55 @@ public AddTableCommand setExecute(boolean exec) {
     return this;
   }
 
-  public boolean execute(JsonNode node)
-      throws IOException {
-    if (_controllerHost == null) {
-      _controllerHost = NetUtil.getHostAddress();
+  public void uploadSchema()
+      throws Exception {
+    File schemaFile;
+    Schema schema;
+    try {
+      schemaFile = new File(_schemaFile);
+      schema = Schema.fromFile(schemaFile);
+    } catch (Exception e) {
+      LOGGER.error("Got exception while reading Pinot schema from file: [" + _schemaFile + "]");
+      throw e;
     }
-    _controllerAddress = "http://" + _controllerHost + ":" + _controllerPort;
-
-    if (!_exec) {
-      LOGGER.warn("Dry Running Command: " + toString());
-      LOGGER.warn("Use the -exec option to actually execute the command.");
-      return true;
+    try (FileUploadDownloadClient fileUploadDownloadClient = new FileUploadDownloadClient()) {
+      fileUploadDownloadClient.addSchema(
+          FileUploadDownloadClient.getUploadSchemaHttpURI(_controllerHost, Integer.parseInt(_controllerPort)),
 
 Review comment:
   Dry run shouldn't upload schema. This check is at line 146.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#discussion_r363488701
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java
 ##########
 @@ -102,33 +111,55 @@ public AddTableCommand setExecute(boolean exec) {
     return this;
   }
 
-  public boolean execute(JsonNode node)
-      throws IOException {
-    if (_controllerHost == null) {
-      _controllerHost = NetUtil.getHostAddress();
+  public void uploadSchema()
+      throws Exception {
+    File schemaFile;
+    Schema schema;
+    try {
+      schemaFile = new File(_schemaFile);
+      schema = Schema.fromFile(schemaFile);
+    } catch (Exception e) {
+      LOGGER.error("Got exception while reading Pinot schema from file: [" + _schemaFile + "]");
+      throw e;
     }
-    _controllerAddress = "http://" + _controllerHost + ":" + _controllerPort;
-
-    if (!_exec) {
-      LOGGER.warn("Dry Running Command: " + toString());
-      LOGGER.warn("Use the -exec option to actually execute the command.");
-      return true;
+    try (FileUploadDownloadClient fileUploadDownloadClient = new FileUploadDownloadClient()) {
+      fileUploadDownloadClient.addSchema(
+          FileUploadDownloadClient.getUploadSchemaHttpURI(_controllerHost, Integer.parseInt(_controllerPort)),
 
 Review comment:
   Dry run shouldn't upload schema. The check is at line 146

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#discussion_r363109466
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java
 ##########
 @@ -66,24 +72,28 @@ public String getName() {
 
   @Override
   public String description() {
-    return "Add table specified in the json file, to the controller.";
+    return "Create Pinot table with table config and schema.";
 
 Review comment:
   ```suggestion
       return "Create a Pinot table";
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#issuecomment-570891639
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=h1) Report
   > Merging [#4959](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9edad92cd19e3e9cd4089a62524405b6e9c9b19a?src=pr&el=desc) will **decrease** coverage by `0.1%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4959/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4959      +/-   ##
   ============================================
   - Coverage     57.63%   57.52%   -0.11%     
     Complexity       12       12              
   ============================================
     Files          1143     1159      +16     
     Lines         61315    61837     +522     
     Branches       9055     9118      +63     
   ============================================
   + Hits          35338    35571     +233     
   - Misses        23346    23614     +268     
   - Partials       2631     2652      +21
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...c/main/java/org/apache/pinot/tools/Quickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1F1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/pinot/tools/HybridQuickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL0h5YnJpZFF1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ava/org/apache/pinot/tools/RealtimeQuickStart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1JlYWx0aW1lUXVpY2tTdGFydC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/pinot/tools/query/comparison/ClusterStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vQ2x1c3RlclN0YXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...pinot/tools/admin/command/GenerateDataCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvR2VuZXJhdGVEYXRhQ29tbWFuZC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...che/pinot/tools/admin/command/AddTableCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQWRkVGFibGVDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...he/pinot/tools/admin/command/QuickstartRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvUXVpY2tzdGFydFJ1bm5lci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...er/validation/BrokerResourceValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL0Jyb2tlclJlc291cmNlVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `25% <0%> (-56.25%)` | `0% <0%> (ø)` | |
   | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
   | ... and [32 more](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=footer). Last update [9edad92...9f9651b](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#discussion_r363383402
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java
 ##########
 @@ -102,33 +111,55 @@ public AddTableCommand setExecute(boolean exec) {
     return this;
   }
 
-  public boolean execute(JsonNode node)
-      throws IOException {
-    if (_controllerHost == null) {
-      _controllerHost = NetUtil.getHostAddress();
+  public void uploadSchema()
+      throws Exception {
+    File schemaFile;
+    Schema schema;
+    try {
+      schemaFile = new File(_schemaFile);
+      schema = Schema.fromFile(schemaFile);
+    } catch (Exception e) {
+      LOGGER.error("Got exception while reading Pinot schema from file: [" + _schemaFile + "]");
+      throw e;
     }
-    _controllerAddress = "http://" + _controllerHost + ":" + _controllerPort;
-
-    if (!_exec) {
-      LOGGER.warn("Dry Running Command: " + toString());
-      LOGGER.warn("Use the -exec option to actually execute the command.");
-      return true;
+    try (FileUploadDownloadClient fileUploadDownloadClient = new FileUploadDownloadClient()) {
+      fileUploadDownloadClient.addSchema(
+          FileUploadDownloadClient.getUploadSchemaHttpURI(_controllerHost, Integer.parseInt(_controllerPort)),
 
 Review comment:
   Do we still want to upload schema if `exec` is not true?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#issuecomment-570891639
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=h1) Report
   > Merging [#4959](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9edad92cd19e3e9cd4089a62524405b6e9c9b19a?src=pr&el=desc) will **decrease** coverage by `0.11%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4959/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4959      +/-   ##
   ============================================
   - Coverage     57.63%   57.52%   -0.12%     
     Complexity       12       12              
   ============================================
     Files          1143     1149       +6     
     Lines         61315    61485     +170     
     Branches       9055     9073      +18     
   ============================================
   + Hits          35338    35368      +30     
   - Misses        23346    23479     +133     
   - Partials       2631     2638       +7
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...c/main/java/org/apache/pinot/tools/Quickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1F1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/pinot/tools/HybridQuickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL0h5YnJpZFF1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ava/org/apache/pinot/tools/RealtimeQuickStart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1JlYWx0aW1lUXVpY2tTdGFydC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/pinot/tools/query/comparison/ClusterStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vQ2x1c3RlclN0YXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...pinot/tools/admin/command/GenerateDataCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvR2VuZXJhdGVEYXRhQ29tbWFuZC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...che/pinot/tools/admin/command/AddTableCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQWRkVGFibGVDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...he/pinot/tools/admin/command/QuickstartRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvUXVpY2tzdGFydFJ1bm5lci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...pache/pinot/core/util/SortedRangeIntersection.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL1NvcnRlZFJhbmdlSW50ZXJzZWN0aW9uLmphdmE=) | `83.82% <0%> (-7.36%)` | `0% <0%> (ø)` | |
   | [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `48.78% <0%> (-7.32%)` | `0% <0%> (ø)` | |
   | ... and [28 more](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=footer). Last update [9edad92...9f9651b](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#discussion_r363109707
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java
 ##########
 @@ -102,33 +112,51 @@ public AddTableCommand setExecute(boolean exec) {
     return this;
   }
 
-  public boolean execute(JsonNode node)
+  public boolean sendTableCreationRequest(JsonNode node)
       throws IOException {
-    if (_controllerHost == null) {
-      _controllerHost = NetUtil.getHostAddress();
-    }
-    _controllerAddress = "http://" + _controllerHost + ":" + _controllerPort;
+    String res = AbstractBaseAdminCommand
+        .sendPostRequest(ControllerRequestURLBuilder.baseUrl(_controllerAddress).forTableCreate(), node.toString());
+    LOGGER.info(res);
+    return res.contains("succesfully added");
+  }
 
+  @Override
+  public boolean execute()
+      throws Exception {
     if (!_exec) {
       LOGGER.warn("Dry Running Command: " + toString());
       LOGGER.warn("Use the -exec option to actually execute the command.");
       return true;
     }
 
-    LOGGER.info("Executing command: " + toString());
-    String res = AbstractBaseAdminCommand
-        .sendPostRequest(ControllerRequestURLBuilder.baseUrl(_controllerAddress).forTableCreate(), node.toString());
+    if (_controllerHost == null) {
+      _controllerHost = NetUtil.getHostAddress();
+    }
+    _controllerAddress = "http://" + _controllerHost + ":" + _controllerPort;
 
-    LOGGER.info(res);
-    if (res.contains("succesfully added")) {
-      return true;
+    LOGGER.info("Executing command: " + toString());
+    // Backward compatible
+    if (_schemaFile != null) {
+      File schemaFile = new File(_schemaFile);
+      if (!schemaFile.exists()) {
+        throw new FileNotFoundException("schema file does not exist: " + _schemaFile);
+      }
+
+      Schema schema = Schema.fromFile(schemaFile);
 
 Review comment:
   You may get an exception here if the schema file is illegal or incorrect format. Not sure what the exception looks like, but it may be better to explicitly field any exception from this call and wrap it into an exception that contains the file name, e.g. "Incorrect schema specification in <schemafilepath>". This way, you can also avoid checking if the file existance in line 141, and combine all exceptions here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io commented on issue #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#issuecomment-570891639
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=h1) Report
   > Merging [#4959](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9edad92cd19e3e9cd4089a62524405b6e9c9b19a?src=pr&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4959/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4959      +/-   ##
   ============================================
   + Coverage     57.63%   57.65%   +0.02%     
     Complexity       12       12              
   ============================================
     Files          1143     1143              
     Lines         61315    61323       +8     
     Branches       9055     9058       +3     
   ============================================
   + Hits          35338    35355      +17     
   + Misses        23346    23340       -6     
   + Partials       2631     2628       -3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ava/org/apache/pinot/tools/RealtimeQuickStart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1JlYWx0aW1lUXVpY2tTdGFydC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...c/main/java/org/apache/pinot/tools/Quickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1F1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/pinot/tools/HybridQuickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL0h5YnJpZFF1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/pinot/tools/query/comparison/ClusterStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vQ2x1c3RlclN0YXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...che/pinot/tools/admin/command/AddTableCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQWRkVGFibGVDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...he/pinot/tools/admin/command/QuickstartRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvUXVpY2tzdGFydFJ1bm5lci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...pinot/tools/admin/command/GenerateDataCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvR2VuZXJhdGVEYXRhQ29tbWFuZC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...er/validation/BrokerResourceValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL0Jyb2tlclJlc291cmNlVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `25% <0%> (-56.25%)` | `0% <0%> (ø)` | |
   | [...e/operator/dociditerators/SortedDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9Tb3J0ZWREb2NJZEl0ZXJhdG9yLmphdmE=) | `47.22% <0%> (-8.34%)` | `0% <0%> (ø)` | |
   | ... and [24 more](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=footer). Last update [9edad92...07dfa9d](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#discussion_r363109752
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java
 ##########
 @@ -102,33 +112,51 @@ public AddTableCommand setExecute(boolean exec) {
     return this;
   }
 
-  public boolean execute(JsonNode node)
+  public boolean sendTableCreationRequest(JsonNode node)
       throws IOException {
-    if (_controllerHost == null) {
-      _controllerHost = NetUtil.getHostAddress();
-    }
-    _controllerAddress = "http://" + _controllerHost + ":" + _controllerPort;
+    String res = AbstractBaseAdminCommand
+        .sendPostRequest(ControllerRequestURLBuilder.baseUrl(_controllerAddress).forTableCreate(), node.toString());
+    LOGGER.info(res);
+    return res.contains("succesfully added");
+  }
 
+  @Override
+  public boolean execute()
+      throws Exception {
     if (!_exec) {
       LOGGER.warn("Dry Running Command: " + toString());
       LOGGER.warn("Use the -exec option to actually execute the command.");
       return true;
     }
 
-    LOGGER.info("Executing command: " + toString());
-    String res = AbstractBaseAdminCommand
-        .sendPostRequest(ControllerRequestURLBuilder.baseUrl(_controllerAddress).forTableCreate(), node.toString());
+    if (_controllerHost == null) {
+      _controllerHost = NetUtil.getHostAddress();
+    }
+    _controllerAddress = "http://" + _controllerHost + ":" + _controllerPort;
 
-    LOGGER.info(res);
-    if (res.contains("succesfully added")) {
-      return true;
+    LOGGER.info("Executing command: " + toString());
+    // Backward compatible
+    if (_schemaFile != null) {
+      File schemaFile = new File(_schemaFile);
+      if (!schemaFile.exists()) {
+        throw new FileNotFoundException("schema file does not exist: " + _schemaFile);
+      }
+
+      Schema schema = Schema.fromFile(schemaFile);
+      try (FileUploadDownloadClient fileUploadDownloadClient = new FileUploadDownloadClient()) {
+        fileUploadDownloadClient.addSchema(
+            FileUploadDownloadClient.getUploadSchemaHttpURI(_controllerHost, Integer.parseInt(_controllerPort)),
+            schema.getSchemaName(), schemaFile);
+      } catch (Exception e) {
+        LOGGER.error("Got Exception to upload Pinot Schema: " + schema.getSchemaName(), e);
+        throw e;
+      }
+    }
+    File tableConfigFile = new File(_tableConfigFile);
+    if (!tableConfigFile.exists()) {
 
 Review comment:
   Maybe same technique can be used here and the file existence check avoided?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959#issuecomment-570891639
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=h1) Report
   > Merging [#4959](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9edad92cd19e3e9cd4089a62524405b6e9c9b19a?src=pr&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4959/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4959      +/-   ##
   ============================================
   + Coverage     57.63%   57.69%   +0.05%     
     Complexity       12       12              
   ============================================
     Files          1143     1143              
     Lines         61315    61323       +8     
     Branches       9055     9058       +3     
   ============================================
   + Hits          35338    35378      +40     
   + Misses        23346    23319      -27     
   + Partials       2631     2626       -5
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ava/org/apache/pinot/tools/RealtimeQuickStart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1JlYWx0aW1lUXVpY2tTdGFydC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...c/main/java/org/apache/pinot/tools/Quickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1F1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/pinot/tools/HybridQuickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL0h5YnJpZFF1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/pinot/tools/query/comparison/ClusterStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vQ2x1c3RlclN0YXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...che/pinot/tools/admin/command/AddTableCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQWRkVGFibGVDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...he/pinot/tools/admin/command/QuickstartRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvUXVpY2tzdGFydFJ1bm5lci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...pinot/tools/admin/command/GenerateDataCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvR2VuZXJhdGVEYXRhQ29tbWFuZC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
   | [.../apache/pinot/core/transport/DataTableHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvRGF0YVRhYmxlSGFuZGxlci5qYXZh) | `88% <0%> (-12%)` | `0% <0%> (ø)` | |
   | ... and [23 more](https://codecov.io/gh/apache/incubator-pinot/pull/4959/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=footer). Last update [9edad92...bcdd16c](https://codecov.io/gh/apache/incubator-pinot/pull/4959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 merged pull request #4959: Add schemaFile as option in AddTableCommand

Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #4959: Add schemaFile as option in AddTableCommand
URL: https://github.com/apache/incubator-pinot/pull/4959
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org