You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Justin Bertram (JIRA)" <ji...@apache.org> on 2018/01/23 16:52:00 UTC
[jira] [Resolved] (ARTEMIS-1409) FindBugs: inefficient use of
keySet iterator instead of entrySet iterator
[ https://issues.apache.org/jira/browse/ARTEMIS-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Bertram resolved ARTEMIS-1409.
-------------------------------------
Resolution: Won't Fix
{{org.apache.activemq.artemis.jms.server.JMSServerManager}} is deprecated so won't fix this.
> FindBugs: inefficient use of keySet iterator instead of entrySet iterator
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-1409
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1409
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Jiri Daněk
> Priority: Minor
>
> Multiple occurrences of code like this
> {noformat}
> 1391 for (String key : props.keySet()) {
> 1392 propstr.append(key);
> 1393 propstr.append("=");
>
> CID 1419417 (#1 of 1): WMI: Inefficient Map Iterator (FB.WMI_WRONG_MAP_ITERATOR)
> 1. defect: org.apache.activemq.artemis.jms.server.impl.JMSServerManagerImpl.listPreparedTransactionDetailsAsHTML() makes inefficient use of keySet iterator instead of entrySet iterator.
> 1394 propstr.append(props.get(key));
> 1395 propstr.append(", ");
> 1396 }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)