[GitHub] [ozone] adoroszlai commented on a change in pull request #1955: HDDS-4840. Make datanode db profile configurable with existing hdds.d…

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #1955:
URL: https://github.com/apache/ozone/pull/1955#discussion_r584635030



##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBProfile.java
##########
@@ -105,8 +105,26 @@ public ColumnFamilyOptions getColumnFamilyOptions() {
       columnFamilyOptions.setCompactionStyle(CompactionStyle.LEVEL);
       return columnFamilyOptions;
     }
+  },
+  // NOTE: just for unit test now, don't use it in production
+  TEST {

Review comment:
       I think we should try to avoid introducing test-specific items in production code.  Why not test with existing `DISK` and `SSD` profiles instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org