You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/05/15 18:32:27 UTC

[commons-configuration] 01/03: Maker some test classes static.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-configuration.git

commit 4bafe3cfbf3ad675b25226a5a412b569e21273c9
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun May 15 13:32:57 2022 -0400

    Maker some test classes static.
---
 .../commons/configuration2/TestDefaultImmutableConfiguration.java       | 2 +-
 .../apache/commons/configuration2/TestDynamicCombinedConfiguration.java | 2 +-
 .../java/org/apache/commons/configuration2/TestXMLConfiguration.java    | 2 +-
 .../commons/configuration2/web/TestServletFilterConfiguration.java      | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/test/java/org/apache/commons/configuration2/TestDefaultImmutableConfiguration.java b/src/test/java/org/apache/commons/configuration2/TestDefaultImmutableConfiguration.java
index d0b97f38..23a6824c 100644
--- a/src/test/java/org/apache/commons/configuration2/TestDefaultImmutableConfiguration.java
+++ b/src/test/java/org/apache/commons/configuration2/TestDefaultImmutableConfiguration.java
@@ -42,7 +42,7 @@ import org.junit.Test;
 public class TestDefaultImmutableConfiguration {
 
     /** Tests default methods. This class MUST NOT override the default methods! */
-    private class MapImmutableConfiguration implements ImmutableConfiguration {
+    private static class MapImmutableConfiguration implements ImmutableConfiguration {
 
         Map<String, Object> map = new HashMap<>();
 
diff --git a/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java b/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java
index 8f0515c7..918ab169 100644
--- a/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java
+++ b/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java
@@ -99,7 +99,7 @@ public class TestDynamicCombinedConfiguration {
         }
 
     }
-    private class ReloadThread extends Thread {
+    private static class ReloadThread extends Thread {
         private final CombinedConfigurationBuilder builder;
         private final int[] failures;
         private final int index;
diff --git a/src/test/java/org/apache/commons/configuration2/TestXMLConfiguration.java b/src/test/java/org/apache/commons/configuration2/TestXMLConfiguration.java
index 8f9ff4fc..9985dfe9 100644
--- a/src/test/java/org/apache/commons/configuration2/TestXMLConfiguration.java
+++ b/src/test/java/org/apache/commons/configuration2/TestXMLConfiguration.java
@@ -74,7 +74,7 @@ public class TestXMLConfiguration {
     /**
      * A thread used for testing concurrent access to a builder.
      */
-    private class ReloadThread extends Thread {
+    private static class ReloadThread extends Thread {
         private final FileBasedConfigurationBuilder<?> builder;
 
         ReloadThread(final FileBasedConfigurationBuilder<?> confBulder) {
diff --git a/src/test/java/org/apache/commons/configuration2/web/TestServletFilterConfiguration.java b/src/test/java/org/apache/commons/configuration2/web/TestServletFilterConfiguration.java
index ff7bfd99..5da734c4 100644
--- a/src/test/java/org/apache/commons/configuration2/web/TestServletFilterConfiguration.java
+++ b/src/test/java/org/apache/commons/configuration2/web/TestServletFilterConfiguration.java
@@ -33,7 +33,7 @@ import org.junit.Test;
  *
  */
 public class TestServletFilterConfiguration extends TestAbstractConfiguration {
-    private class MockFilterConfig implements FilterConfig {
+    private static class MockFilterConfig implements FilterConfig {
         private final Properties parameters = new Properties();
 
         @Override