You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/04/16 15:58:19 UTC
[jira] [Commented] (BOOKKEEPER-218) Provide journal manager to
manage journal related operations
[ https://issues.apache.org/jira/browse/BOOKKEEPER-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254702#comment-13254702 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-218:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4737/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
Currently we put all journal related operations in Bookie class. It would be better to provide a journal manager to provide journal related operations. It would make Bookie logic more clearly.
Besides that, some admin tools like BOOKKEEPER-183 needs to provide could use JournalManager to read/check journal files directly.
This addresses bug BOOKKEEPER-218.
https://issues.apache.org/jira/browse/BOOKKEEPER-218
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java bbf561a
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieBean.java fa5171b
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieMXBean.java 8418469
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalManager.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java c172224
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieJournalRollingTest.java e795fce
Diff: https://reviews.apache.org/r/4737/diff
Testing
-------
Thanks,
Sijie
> Provide journal manager to manage journal related operations
> ------------------------------------------------------------
>
> Key: BOOKKEEPER-218
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-218
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-218.diff
>
>
> Currently we put all journal related operations in Bookie class. It would be better to provide a journal manager to provide journal related operations. It would make Bookie logic more clearly.
> Besides that, some admin tools like BOOKKEEPER-183 needs to provide could use JournalManager to read/check journal files directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira