You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sandeep Tata (JIRA)" <ji...@apache.org> on 2009/09/24 03:19:16 UTC
[jira] Created: (CASSANDRA-456) CommitLog should log RowMutations,
not Rows
CommitLog should log RowMutations, not Rows
-------------------------------------------
Key: CASSANDRA-456
URL: https://issues.apache.org/jira/browse/CASSANDRA-456
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.4
Environment: All
Reporter: Sandeep Tata
Assignee: Sandeep Tata
Priority: Minor
Commitlog and Table.apply use Row objects instead of RowMutations. This is an unnecessary conversion. Rows are typically used to return results while RM should be used for the insert/update/delete path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-456) CommitLog should log RowMutations,
not Rows
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandeep Tata updated CASSANDRA-456:
-----------------------------------
Attachment: 456.patch
CommitLog and Table.apply/applyNow/load paths use RMs directly instead of converting to Rows first.
> CommitLog should log RowMutations, not Rows
> -------------------------------------------
>
> Key: CASSANDRA-456
> URL: https://issues.apache.org/jira/browse/CASSANDRA-456
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Environment: All
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Attachments: 456.patch
>
>
> Commitlog and Table.apply use Row objects instead of RowMutations. This is an unnecessary conversion. Rows are typically used to return results while RM should be used for the insert/update/delete path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-456) CommitLog should log
RowMutations, not Rows
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759227#action_12759227 ]
Jonathan Ellis commented on CASSANDRA-456:
------------------------------------------
committed w/ minor revisions (biggest was removing RM.clear and the call from apply that isn't actually needed)
> CommitLog should log RowMutations, not Rows
> -------------------------------------------
>
> Key: CASSANDRA-456
> URL: https://issues.apache.org/jira/browse/CASSANDRA-456
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Environment: All
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 456.patch
>
>
> Commitlog and Table.apply use Row objects instead of RowMutations. This is an unnecessary conversion. Rows are typically used to return results while RM should be used for the insert/update/delete path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-456) CommitLog should log
RowMutations, not Rows
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760487#action_12760487 ]
Jonathan Ellis commented on CASSANDRA-456:
------------------------------------------
Belatedly realized this breaks disk compatibility for 0.4 -> 05. Not too bad though, since clearing out commitlog segments is easily done.
> CommitLog should log RowMutations, not Rows
> -------------------------------------------
>
> Key: CASSANDRA-456
> URL: https://issues.apache.org/jira/browse/CASSANDRA-456
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Environment: All
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 456.patch
>
>
> Commitlog and Table.apply use Row objects instead of RowMutations. This is an unnecessary conversion. Rows are typically used to return results while RM should be used for the insert/update/delete path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-456) CommitLog should log RowMutations,
not Rows
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-456:
-------------------------------------
Fix Version/s: 0.5
> CommitLog should log RowMutations, not Rows
> -------------------------------------------
>
> Key: CASSANDRA-456
> URL: https://issues.apache.org/jira/browse/CASSANDRA-456
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Environment: All
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 456.patch
>
>
> Commitlog and Table.apply use Row objects instead of RowMutations. This is an unnecessary conversion. Rows are typically used to return results while RM should be used for the insert/update/delete path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-456) CommitLog should log
RowMutations, not Rows
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759511#action_12759511 ]
Hudson commented on CASSANDRA-456:
----------------------------------
Integrated in Cassandra #208 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/208/])
CommitLog and Table.apply/applyNow/load paths use RMs directly instead of converting to Rows first. patch by Sandeep Tata; reviewed by jbellis for
> CommitLog should log RowMutations, not Rows
> -------------------------------------------
>
> Key: CASSANDRA-456
> URL: https://issues.apache.org/jira/browse/CASSANDRA-456
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Environment: All
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 456.patch
>
>
> Commitlog and Table.apply use Row objects instead of RowMutations. This is an unnecessary conversion. Rows are typically used to return results while RM should be used for the insert/update/delete path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.