You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/25 04:27:10 UTC

[GitHub] [incubator-superset] TheLastSultan opened a new pull request #8291: Bug Fix: Select box now searchable by verbose tags

TheLastSultan opened a new pull request #8291: Bug Fix: Select box now searchable by verbose tags
URL: https://github.com/apache/incubator-superset/pull/8291
 
 
   ### CATEGORY
   
   Choose one
   
   - [x ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Issue documented separately in depth:
   https://github.com/apache/incubator-superset/issues/8288
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   ![image](https://user-images.githubusercontent.com/41172775/65543235-a3d3c880-dec5-11e9-935f-cc3cbd62bfec.png)
   
   ![image](https://user-images.githubusercontent.com/41172775/65543272-b0582100-dec5-11e9-816a-3ad3702bbc48.png)
   
   ### TEST PLAN
   1. Go to Datasources or Tables, Edit Column, and pick a random column to edit
   2. Change 'verbose_name' of the random column to 'willis'
   2. Try to search by 'willis' when creating a slice
   3. You will find that you can only pull it up by 'id' or whatever the original value was
   4. Validate that Filterbox is now searchable by original column name and new column name
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org