You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/08/13 22:59:43 UTC
Review Request 68333: Made CNI isolator cleanup more robust.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68333/
-----------------------------------------------------------
Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
Bugs: MESOS-9142
https://issues.apache.org/jira/browse/MESOS-9142
Repository: mesos
Description
-------
If the container is destroyed while in isolator preparing state, the
cleanup might fail due to missing files or directories. This patch makes
the cleanup path in CNI isolator more robust so that the cleanup does
not fail in those scenarios.
Diffs
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f46c962d8f044092aaa113fafc536c6b25bab45c
Diff: https://reviews.apache.org/r/68333/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 68333: Made CNI isolator cleanup more robust.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68333/#review207214
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Aug. 14, 2018, 6:59 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68333/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 6:59 a.m.)
>
>
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the container is destroyed while in isolator preparing state, the
> cleanup might fail due to missing files or directories. This patch makes
> the cleanup path in CNI isolator more robust so that the cleanup does
> not fail in those scenarios.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f46c962d8f044092aaa113fafc536c6b25bab45c
>
>
> Diff: https://reviews.apache.org/r/68333/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68333: Made CNI isolator cleanup more robust.
Posted by Deepak Goel <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68333/#review207192
-----------------------------------------------------------
Ship it!
Ship It!
- Deepak Goel
On Aug. 13, 2018, 10:59 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68333/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 10:59 p.m.)
>
>
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the container is destroyed while in isolator preparing state, the
> cleanup might fail due to missing files or directories. This patch makes
> the cleanup path in CNI isolator more robust so that the cleanup does
> not fail in those scenarios.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f46c962d8f044092aaa113fafc536c6b25bab45c
>
>
> Diff: https://reviews.apache.org/r/68333/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68333: Made CNI isolator cleanup more robust.
Posted by Sergey Urbanovich <se...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68333/#review207194
-----------------------------------------------------------
Ship it!
Ship It!
- Sergey Urbanovich
On Aug. 13, 2018, 10:59 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68333/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 10:59 p.m.)
>
>
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the container is destroyed while in isolator preparing state, the
> cleanup might fail due to missing files or directories. This patch makes
> the cleanup path in CNI isolator more robust so that the cleanup does
> not fail in those scenarios.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f46c962d8f044092aaa113fafc536c6b25bab45c
>
>
> Diff: https://reviews.apache.org/r/68333/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>