Re: .DS_Store annoyance on the Mac

[Jonathan Gallimore <jo...@gmail.com>]

I've been playing around with this today, and I've created a patch which
I've attached to OPENEJB-1057.

What I'm doing is looking at the deployments section of openejb.xml (I've
added an extra attribute called excludes to Deployments), and ignoring files
which match the pattern specified.

The problem I've run into is that in order to exclude files in the webapps
directory when running in Tomcat, you need to add a <Deployments
dir="webapps/" /> which causes everything in the webapps folder to be
deployed from DeploymentsResolver instead of TomcatWebAppBuilder, and that
give exceptions about looking for tag libraries.

We could ignore <Deployments> for the webapps folder in DeploymentsResolver
if we're running in Tomcat - or perhaps there's a better way?

Anyone have any thoughts?

Cheers

Jon

On Wed, Aug 5, 2009 at 4:43 PM, Karan Malhi <ka...@gmail.com> wrote:

> I agree that something configurable would be better.
>
> On Wed, Aug 5, 2009 at 7:41 AM, Jacek Laskowski <jacek@laskowski.net.pl
> >wrote:
>
> > On Wed, Aug 5, 2009 at 12:07 AM, Jonathan
> > Gallimore<jo...@gmail.com> wrote:
> > > I've had a look at this, and it looks like we look at all the files in
> > the
> > > webapps folder when running in Tomcat. I've made this really simple
> patch
> > > which will ignore any files starting with a dot:
> >
> > Looks fine, but having an option to configure what to skip from
> > processing would be even better :)
> >
> > Jacek
> >
> > --
> > Jacek Laskowski
> > Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl
> >
>
>
>
> --
> Karan Singh Malhi
>

Re: .DS_Store annoyance on the Mac

[Jonathan Gallimore <jo...@gmail.com>]

Hi Jean-Louis,

It is ignored at the moment, however I added some code to process
<Deployments> in openejb.xml as part of this work so that we could figure
out what to ignore.

It seems the the ability to control what is ignored is desirable and
Openejb.xml seemed like a good place to specify it. I'm open to configuring
this setting in another way.

Currently I'm leaning towards just ignoring a <Deployments dir="webapps/"/>
tag in DeploymentsResolver when we're running in Tomcat to solve the
problem, but I'm interested in any ideas anyone has.

Jon

On Mon, Sep 7, 2009 at 8:46 PM, Jean-Louis MONTEIRO <
jean-louis.monteiro@atosorigin.com> wrote:

>
> Hi Jon,
>
> Cool to share with you again.
> When running in Tomcat, i initially thought <Deployment .. /> was ignored.
>
>
> Jonathan Gallimore-2 wrote:
> >
> > We could ignore <Deployments> for the webapps folder in
> > DeploymentsResolver
> > if we're running in Tomcat - or perhaps there's a better way?
> >
>
> I guess it does not make sense to deal with.
>
> Jean-Louis
>
> --
> View this message in context:
> http://www.nabble.com/Re%3A-.DS_Store-annoyance-on-the-Mac-tp24817183p25335405.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>
>

Re: .DS_Store annoyance on the Mac

[Jean-Louis MONTEIRO <je...@atosorigin.com>]

Hi Jon,

Cool to share with you again.
When running in Tomcat, i initially thought <Deployment .. /> was ignored.


Jonathan Gallimore-2 wrote:
> 
> We could ignore <Deployments> for the webapps folder in
> DeploymentsResolver
> if we're running in Tomcat - or perhaps there's a better way?
> 

I guess it does not make sense to deal with.

Jean-Louis

-- 
View this message in context: http://www.nabble.com/Re%3A-.DS_Store-annoyance-on-the-Mac-tp24817183p25335405.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: .DS_Store annoyance on the Mac

[Jonathan Gallimore <jo...@gmail.com>]

That's right - with the patch in its current form, just adding:

<Deployments dir="apps/" excludes="Thumbs\.db"/>

to openejb.xml would do what you want.

Jon

On Mon, Sep 7, 2009 at 8:09 PM, Daniel S. Haischt <
daniel.haischt@googlemail.com> wrote:

> Hi,
>
> I understand once you have this implemented accordingly one would as
> well be able to exclude the infamous Thumbs.db on windoze, right ?
>
> Cheers
> Daniel
>
> On Sun, Sep 6, 2009 at 11:48 PM, Jonathan
> Gallimore<jo...@gmail.com> wrote:
> > I've been playing around with this today, and I've created a patch which
> > I've attached to OPENEJB-1057.
> >
> > What I'm doing is looking at the deployments section of openejb.xml (I've
> > added an extra attribute called excludes to Deployments), and ignoring
> files
> > which match the pattern specified.
> >
> > The problem I've run into is that in order to exclude files in the
> webapps
> > directory when running in Tomcat, you need to add a <Deployments
> > dir="webapps/" /> which causes everything in the webapps folder to be
> > deployed from DeploymentsResolver instead of TomcatWebAppBuilder, and
> that
> > give exceptions about looking for tag libraries.
> >
> > We could ignore <Deployments> for the webapps folder in
> DeploymentsResolver
> > if we're running in Tomcat - or perhaps there's a better way?
> >
> > Anyone have any thoughts?
> >
> > Cheers
> >
> > Jon
> >
> > On Wed, Aug 5, 2009 at 4:43 PM, Karan Malhi <ka...@gmail.com>
> wrote:
> >
> >> I agree that something configurable would be better.
> >>
> >> On Wed, Aug 5, 2009 at 7:41 AM, Jacek Laskowski <jacek@laskowski.net.pl
> >> >wrote:
> >>
> >> > On Wed, Aug 5, 2009 at 12:07 AM, Jonathan
> >> > Gallimore<jo...@gmail.com> wrote:
> >> > > I've had a look at this, and it looks like we look at all the files
> in
> >> > the
> >> > > webapps folder when running in Tomcat. I've made this really simple
> >> patch
> >> > > which will ignore any files starting with a dot:
> >> >
> >> > Looks fine, but having an option to configure what to skip from
> >> > processing would be even better :)
> >> >
> >> > Jacek
> >> >
> >> > --
> >> > Jacek Laskowski
> >> > Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl
> >> >
> >>
> >>
> >>
> >> --
> >> Karan Singh Malhi
> >>
> >
>

Re: .DS_Store annoyance on the Mac

["Daniel S. Haischt" <da...@googlemail.com>]

Hi,

I understand once you have this implemented accordingly one would as
well be able to exclude the infamous Thumbs.db on windoze, right ?

Cheers
Daniel

On Sun, Sep 6, 2009 at 11:48 PM, Jonathan
Gallimore<jo...@gmail.com> wrote:
> I've been playing around with this today, and I've created a patch which
> I've attached to OPENEJB-1057.
>
> What I'm doing is looking at the deployments section of openejb.xml (I've
> added an extra attribute called excludes to Deployments), and ignoring files
> which match the pattern specified.
>
> The problem I've run into is that in order to exclude files in the webapps
> directory when running in Tomcat, you need to add a <Deployments
> dir="webapps/" /> which causes everything in the webapps folder to be
> deployed from DeploymentsResolver instead of TomcatWebAppBuilder, and that
> give exceptions about looking for tag libraries.
>
> We could ignore <Deployments> for the webapps folder in DeploymentsResolver
> if we're running in Tomcat - or perhaps there's a better way?
>
> Anyone have any thoughts?
>
> Cheers
>
> Jon
>
> On Wed, Aug 5, 2009 at 4:43 PM, Karan Malhi <ka...@gmail.com> wrote:
>
>> I agree that something configurable would be better.
>>
>> On Wed, Aug 5, 2009 at 7:41 AM, Jacek Laskowski <jacek@laskowski.net.pl
>> >wrote:
>>
>> > On Wed, Aug 5, 2009 at 12:07 AM, Jonathan
>> > Gallimore<jo...@gmail.com> wrote:
>> > > I've had a look at this, and it looks like we look at all the files in
>> > the
>> > > webapps folder when running in Tomcat. I've made this really simple
>> patch
>> > > which will ignore any files starting with a dot:
>> >
>> > Looks fine, but having an option to configure what to skip from
>> > processing would be even better :)
>> >
>> > Jacek
>> >
>> > --
>> > Jacek Laskowski
>> > Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl
>> >
>>
>>
>>
>> --
>> Karan Singh Malhi
>>
>