[GitHub] storm issue #1674: STORM-2083: Blacklist scheduler

[nilday <gi...@git.apache.org>]

Github user nilday commented on the issue:

    https://github.com/apache/storm/pull/1674
  
    As soon as I find out that nimbus  has been transferred to Java, I start to work on this again. The blacklist scheduler has been working on our production environment(Storm v1.0.1) for several months and it worked fine!
     I read carefully for all your suggestions and try to fix our improve them in some way. Here them are listed:
    [X] Add Apache Header
    [X] Remove AuthorInfo
    [X] space between =, ? and :
    [X] unnecessary new line
    [X] q more readable
    [X] move CircularBuffer main to a unit test
    [X] remove comment in DefaultBlacklistStrategy.java#L54
    [X] work on master
    [X] blacklist scheduler wrap others in nimbus
    [ ] blacklist on UI
    [X] blacklist to metric
    [X] avoid wildcard imports
    [X]  ...che/storm/scheduler/blacklist/BlacklistScheduler.java#L66 strategyClassName
    [X] Adding space around =, +, :, <, etc
    [X] NPE when blacklistStrategy or reporter can't be found
    [X] toleranceBuffer type and name misleading
    [X] Remove unused comments in IBlacklistStrategy
    
    For the UI work, I may open another issue and work on it. The rest works are listed above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---