[GitHub] [ozone] smengcl commented on a diff in pull request #4264: HDDS-7950. [Snapshot] API changes to support pagination token and async nature of snapshot diff API

["smengcl (via GitHub)" <gi...@apache.org>]

smengcl commented on code in PR #4264:
URL: https://github.com/apache/ozone/pull/4264#discussion_r1122479889


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/SnapshotDiffHandler.java:
##########
@@ -45,6 +45,14 @@ public class SnapshotDiffHandler extends Handler {
       index = "2")
   private String toSnapshot;
 
+  @CommandLine.Option(names = {"-t", "--token"},
+      description = "token (optional) ")
+  private String token;
+
+  @CommandLine.Option(names = {"-p", "--pageSize"},

Review Comment:
   ```suggestion
     @CommandLine.Option(names = {"-p", "--page-size"},
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org