You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/01 03:41:00 UTC

[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #107: feat: catching exceptions thrown during the writeAndFlush

tzssangglass opened a new pull request #107:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/107


   Signed-off-by: tzssangglass <tz...@gmail.com>
   
   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   Add a ChannelFutureListener and a custom ExceptionCaughtHandler to catch exceptions that may be thrown during the writeAndFlush phase to prevent them from being swallowed.
   
   refer to: https://github.com/apache/apisix-java-plugin-runner/blob/3da21b98fc435dc239af6f1d8a9ceebdd6f1686f/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpResponse.java#L70
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-java-plugin-runner] tzssangglass merged pull request #107: feat: catching exceptions thrown during the writeAndFlush

Posted by GitBox <gi...@apache.org>.
tzssangglass merged pull request #107:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/107


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #107: feat: catching exceptions thrown during the writeAndFlush

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #107:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/107#issuecomment-1003863454


   > should add some test cases for the change
   
   tried but failed, I can't find the right way to hack  `ctx.writeAndFlush(currResp);`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org