You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "liujiacheng777 (via GitHub)" <gi...@apache.org> on 2023/03/27 12:00:07 UTC
[GitHub] [arrow] liujiacheng777 opened a new pull request, #34740: Add support for LoongArch
liujiacheng777 opened a new pull request, #34740:
URL: https://github.com/apache/arrow/pull/34740
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
Add support for LoongArch, please review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1569999245
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b1a5be1a9a7a432fb5bb7426ecbf2a5b...71d4e1bc06084c13908233e67e879e0b/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34740:
URL: https://github.com/apache/arrow/pull/34740#discussion_r1151163358
##########
cpp/src/arrow/vendored/double-conversion/utils.h:
##########
@@ -102,6 +102,7 @@ int main(int argc, char** argv) {
defined(__AARCH64EL__) || defined(__aarch64__) || defined(__AARCH64EB__) || \
defined(__riscv) || \
defined(__or1k__) || defined(__arc__) || \
+ defined(__loongarch__) || \
Review Comment:
Could you open a pull request to upstream https://github.com/google/double-conversion ?
We'll update our bundled version after this change is merged in upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34740: GH-34752: Add support for LoongArch
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1486117769
:warning: GitHub issue #34752 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34740: MINOR: Add support for LoongArch
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1485809597
Could you open an issue for this pull request? This is not a minor change.
See also:
> If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
>
> Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
>
> Then could you also rename the pull request title in the following format?
>
> ```
> GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
> ```
>
> ...
>
> See also:
>
> * [Other pull requests](https://github.com/apache/arrow/pulls/)
>
> * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1511027257
This is blocked by #34919.
I want to resolve https://github.com/apache/arrow/pull/34919#issuecomment-1501420706 before we merge #34919.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] loongson-zn commented on a diff in pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "loongson-zn (via GitHub)" <gi...@apache.org>.
loongson-zn commented on code in PR #34740:
URL: https://github.com/apache/arrow/pull/34740#discussion_r1151683673
##########
cpp/src/arrow/vendored/double-conversion/utils.h:
##########
@@ -102,6 +102,7 @@ int main(int argc, char** argv) {
defined(__AARCH64EL__) || defined(__aarch64__) || defined(__AARCH64EB__) || \
defined(__riscv) || \
defined(__or1k__) || defined(__arc__) || \
+ defined(__loongarch__) || \
Review Comment:
https://github.com/google/double-conversion/pull/162/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liujiacheng777 commented on pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "liujiacheng777 (via GitHub)" <gi...@apache.org>.
liujiacheng777 commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1490035707
https://github.com/apache/arrow/pull/34793
I have individually modified as required，Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34740:
URL: https://github.com/apache/arrow/pull/34740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34740:
URL: https://github.com/apache/arrow/pull/34740#discussion_r1152407998
##########
cpp/src/arrow/vendored/double-conversion/utils.h:
##########
@@ -102,6 +102,7 @@ int main(int argc, char** argv) {
defined(__AARCH64EL__) || defined(__aarch64__) || defined(__AARCH64EB__) || \
defined(__riscv) || \
defined(__or1k__) || defined(__arc__) || \
+ defined(__loongarch__) || \
Review Comment:
Thanks.
Then could you open a new separated issue to update vendored double-conversion and open a separated pull request for it?
For example, #14817 is a pull request to update vendored fast_float.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] loongson-zn commented on pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "loongson-zn (via GitHub)" <gi...@apache.org>.
loongson-zn commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1560618362
I see that https://github.com/apache/arrow/pull/34919#issue-1656545063 already been merged !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liujiacheng777 commented on pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "liujiacheng777 (via GitHub)" <gi...@apache.org>.
liujiacheng777 commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1490033055
https://github.com/apache/arrow/pull/34793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34740: GH-34752: Add support for LoongArch
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1486117742
* Closes: #34752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #34740: GH-34752: Add support for LoongArch
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1486619882
By the way, do we have (or need have) CI for all the architectures? @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1569296519
Benchmark runs are scheduled for baseline = 95c33d82e67c9500b08ea7086a46b447d65bc14b and contender = 313fb4009c371dc42a925b3ee59bf9db53a1921a. 313fb4009c371dc42a925b3ee59bf9db53a1921a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/13cd4b5b224b49698bdfe3cc0c6bd35b...c6a3ea6eeb6e4d9f833f4fac464ee536/)
[Failed :arrow_down:0.72% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/355e88df5cda4cdfbc0c648cad497b05...cd410f001a2947479f22fadef4c5c59c/)
[Failed :arrow_down:4.1% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b1a5be1a9a7a432fb5bb7426ecbf2a5b...71d4e1bc06084c13908233e67e879e0b/)
[Failed :arrow_down:0.47% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8ef5670afb5e484c92f38b027458a126...d2f4b3a5de184593a9a74d1763183160/)
Buildkite builds:
[Finished] [`313fb400` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2929)
[Failed] [`313fb400` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2965)
[Finished] [`313fb400` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2930)
[Failed] [`313fb400` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2955)
[Finished] [`95c33d82` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2928)
[Failed] [`95c33d82` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2964)
[Failed] [`95c33d82` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2929)
[Failed] [`95c33d82` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2954)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- commented on pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1511019947
This seems to be blocked by https://github.com/apache/arrow/pull/34793 as far as I can understand. But the other one is closed, if it's just updating the version of a vendored lib and the tests are passing, should we merge it and unblock this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34740: Add support for LoongArch
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1485017694
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1487604696
It's better but we don't require it. Because it's difficult to have CI for all supported platforms. We can use QEMU on x86_64 but the approach has a performance problem.
For example, we have some s390x CI jobs on Travis CI but we'll abandon them because ASF stopped Travis CI support.
@liujiacheng777 Could you run C++ unit tests on your environment because we can't do it in CI?
https://arrow.apache.org/docs/dev/developers/cpp/development.html#running-unit-tests
(You also need to read https://arrow.apache.org/docs/dev/developers/cpp/index.html to run unit tests.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34740: GH-34752: [C++] Add support for LoongArch
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34740:
URL: https://github.com/apache/arrow/pull/34740#issuecomment-1560643855
Could you rebase on main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org