You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2021/05/03 21:12:11 UTC

[GitHub] [avro] Fokko commented on a change in pull request #1206: AVRO-3048: Use SpecificRecord's MODEL$ in builder creation

Fokko commented on a change in pull request #1206:
URL: https://github.com/apache/avro/pull/1206#discussion_r625371128



##########
File path: lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm
##########
@@ -338,7 +338,7 @@ static {
      */
     private Builder(#if ($schema.getNamespace())$this.mangle($schema.getNamespace()).#end${this.mangle($schema.getName())} other) {
 #if ($schema.isError())      super(other)#else
-      super(SCHEMA$)#end;
+      super(SCHEMA$,MODEL$)#end;

Review comment:
       Thanks @RyanSkraba for the review
   ```suggestion
         super(SCHEMA$, MODEL$)#end;
   ```
   @unchuckable Don't forget this one :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org