You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wegod (via GitHub)" <gi...@apache.org> on 2023/05/25 02:51:17 UTC

[GitHub] [dubbo] wegod opened a new pull request, #12397: Refactor alibaba URL.java with proxy

wegod opened a new pull request, #12397:
URL: https://github.com/apache/dubbo/pull/12397

   fix https://github.com/apache/dubbo/issues/12376
   and make proxy of some methods defined in apache URL.java
   
   ## What is the purpose of the change
   
   fix https://github.com/apache/dubbo/issues/12376
   
   ## Brief changelog
   
   Use proxy in alibaba URL.java instead of call super methods.
   Then some URL's child implements won't be lose in alibaba URL
   
   ## Verifying this change
   
   Base test on my local env
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [x] Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [x] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [x] GitHub Actions works fine on your own branch.
   - [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] wegod closed pull request #12397: Refactor alibaba URL.java with proxy

Posted by "wegod (via GitHub)" <gi...@apache.org>.
wegod closed pull request #12397: Refactor alibaba URL.java with proxy
URL: https://github.com/apache/dubbo/pull/12397


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] wegod commented on pull request #12397: Refactor alibaba URL.java with proxy

Posted by "wegod (via GitHub)" <gi...@apache.org>.
wegod commented on PR #12397:
URL: https://github.com/apache/dubbo/pull/12397#issuecomment-1567044644

   @AlbumenJ PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org