You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/19 18:06:21 UTC

[GitHub] [skywalking] wu-sheng commented on issue #3658: Make agent plugin tests in PR only necessary.

wu-sheng commented on issue #3658: Make agent plugin tests in PR only necessary.
URL: https://github.com/apache/skywalking/issues/3658#issuecomment-544181967
 
 
   There is one hard job in this, which is the submodule update check. So, we have to compare the file after `submodule update`, but exclude the `.gitsubmodule` file.
   
   Let's work on a general shell to set the fast-success mechanism in the CI process. In this shell, we could set up compare folders and files, if all of those are unchanged, then we turn the job into fast success, even without compile requirement.
   
   As a result, we should have
   1.  e2e tests should run in source code changes or Jenkins control file changes.
   1. plugin tests should run in agent and agent protocol changes or Jenkins control file changes.
   1. CI should run in source code changes or Jenkins control file changes.
   1. No CI, e2e and plugin tests should be run if only document changes.
   
   All these should accelerate the speed of PR review, and make our VM usage for real good requirements.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services