[GitHub] [cordova-android] dpogue commented on a change in pull request #764: App bundle

[GitBox <gi...@apache.org>]

dpogue commented on a change in pull request #764: App bundle
URL: https://github.com/apache/cordova-android/pull/764#discussion_r302570987
 
 

 ##########
 File path: bin/templates/cordova/lib/build.js
 ##########
 @@ -148,10 +150,17 @@ module.exports.run = function (options, optResolvedTarget) {
             return;
         }
         return builder.build(opts).then(function () {
-            var apkPaths = builder.findOutputApks(opts.buildType, opts.arch);
-            events.emit('log', 'Built the following apk(s): \n\t' + apkPaths.join('\n\t'));
+            var paths;
+            if (opts.isBundle) {
+                paths = builder.findOutputBundles(opts.buildType);
+                events.emit('log', 'Built the following bundle(s): \n\t' + paths.join('\n\t'));
+            } else {
+                paths = builder.findOutputApks(opts.buildType, opts.arch);
+                events.emit('log', 'Built the following apk(s): \n\t' + paths.join('\n\t'));
+            }
+
             return {
-                apkPaths: apkPaths,
+                paths: paths,
 
 Review comment:
   Technically speaking, changing the name of the key in the returned object is probably a breaking API change, and might require changes to stuff like the `run` command or cordova-lib and other tooling.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org