You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/02/27 00:27:41 UTC
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12616
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
IMPALA-8252: Only write node_metadata if it's set
Since IMPALA-1048 we write TRuntimeProfileNode.node_metadata
unconditionally, even when both its fields are unset. This trips up the
Thrift library Java reader code, which expects to find exactly one type
of a union to be set.
This change fixes the issue by checking whether at least one of the
fields is set before marking node_metadata as set.
To test this I wrote a profile and then manually read it with a Java
client.
Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
---
M be/src/util/runtime-profile.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/12616/1
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 08:00:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3839/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 01:29:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12616/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12616/2//COMMIT_MSG@17
PS2, Line 17: To test this I wrote a profile and then manually read it with a Java
Can you maybe add a regression test to runtime-profile-test.cc. It seems like we should be able to test this directly.
http://gerrit.cloudera.org:8080/#/c/12616/2/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:
http://gerrit.cloudera.org:8080/#/c/12616/2/be/src/util/runtime-profile.cc@940
PS2, Line 940: if (metadata_.__isset.plan_node_id || metadata_.__isset.data_sink_id) {
Kind of subtle, maybe leave a comment so it makes sense.
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 00:32:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12616
to look at the new patch set (#3).
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
IMPALA-8252: Only write node_metadata if it's set
Since IMPALA-1048 we write TRuntimeProfileNode.node_metadata
unconditionally, even when both its fields are unset. This trips up the
Thrift library Java reader code, which expects to find exactly one type
of a union to be set.
This change fixes the issue by checking whether at least one of the
fields is set before marking node_metadata as set.
This change also adds a test to runtime-profile-test.cc to make sure
that the __isset flag is set correctly. Additionally I wrote a profile
and then manually read it with a Java client.
Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
---
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
2 files changed, 22 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/12616/3
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2266/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 00:54:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 2:
I couldn't think of an easy way to test this change manually, at least before we have IMPALA-8158 in place to retrieve thrift profiles through HS2.
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 00:30:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 4: Code-Review+2
Added test to list of backend tests, carrying Tim's +2
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 03:37:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12616
to look at the new patch set (#4).
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
IMPALA-8252: Only write node_metadata if it's set
Since IMPALA-1048 we write TRuntimeProfileNode.node_metadata
unconditionally, even when both its fields are unset. This trips up the
Thrift library Java reader code, which expects to find exactly one type
of a union to be set.
This change fixes the issue by checking whether at least one of the
fields is set before marking node_metadata as set.
This change also adds a test to runtime-profile-test.cc to make sure
that the __isset flag is set correctly. Additionally I wrote a profile
and then manually read it with a Java client.
Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
---
M be/src/util/CMakeLists.txt
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
3 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/12616/4
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2267/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 01:34:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12616/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12616/2//COMMIT_MSG@17
PS2, Line 17: To test this I wrote a profile and then manually read it with a Java
> Can you maybe add a regression test to runtime-profile-test.cc. It seems li
Done
http://gerrit.cloudera.org:8080/#/c/12616/2/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:
http://gerrit.cloudera.org:8080/#/c/12616/2/be/src/util/runtime-profile.cc@940
PS2, Line 940: if (metadata_.__isset.plan_node_id || metadata_.__isset.data_sink_id) {
> Kind of subtle, maybe leave a comment so it makes sense.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 01:10:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3839/
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 02:17:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3841/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 03:37:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2271/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 04:10:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
IMPALA-8252: Only write node_metadata if it's set
Since IMPALA-1048 we write TRuntimeProfileNode.node_metadata
unconditionally, even when both its fields are unset. This trips up the
Thrift library Java reader code, which expects to find exactly one type
of a union to be set.
This change fixes the issue by checking whether at least one of the
fields is set before marking node_metadata as set.
This change also adds a test to runtime-profile-test.cc to make sure
that the __isset flag is set correctly. Additionally I wrote a profile
and then manually read it with a Java client.
Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Reviewed-on: http://gerrit.cloudera.org:8080/12616
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/CMakeLists.txt
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
3 files changed, 23 insertions(+), 2 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 )
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 01:27:31 +0000
Gerrit-HasComments: No