You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "wt-better (via GitHub)" <gi...@apache.org> on 2024/02/22 02:39:53 UTC

[PR] feature: saga-remove spring [incubator-seata]

wt-better opened a new pull request, #6370:
URL: https://github.com/apache/incubator-seata/pull/6370

   - [x] I have registered the PR [changes](../changes).
   
   ### Ⅰ. Describe what this PR did
   
   Seata saga current is strong dependency on spring. such as: 
   
   1. code was dependency spring beans (InitializingBean ..etc)
   2. expression evaluation dependency spring el 
   3. spring bean service Task dependency spring ioc 
   
   This is not conducive to saga's multilanguage building, so I has decouple saga with spring.
   
   1. To ensure code compatibility, make new module named 'seata-saga-spring' and move related classes(not modified path) to this module.
   
   2. 'seata-saga-tm' has spring dependency, this module is not necessary. First I removed this module and move class to 'seata-saga-spring' , I will sink TM's core capabilities ‘seata-saga-engine’ module later pr.
   
   3. 'seata-saga-engine-store' remove the implementation of serialization and make it more pure
   
   4. 'seata-saga-rm' has class named `StateMachineEngineHolder`, i moved to ‘seata-saga-engine’ module, and package name change, it`s not compatible. why ? I think it is inner use, users rarely use it.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] feature: saga-remove spring [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6370:
URL: https://github.com/apache/incubator-seata/pull/6370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] feature: saga-remove spring [incubator-seata]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6370:
URL: https://github.com/apache/incubator-seata/pull/6370#issuecomment-1968466859

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `1.92308%` with `51 lines` in your changes are missing coverage. Please review.
   > Project coverage is 50.90%. Comparing base [(`ed41072`)](https://app.codecov.io/gh/apache/incubator-seata/commit/ed410721a404d7ae7d51aca4402e4fbd722ed3e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`34b8fe6`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 6 commits behind head on 2.x.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/6370/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@             Coverage Diff              @@
   ##                2.x    #6370      +/-   ##
   ============================================
   - Coverage     52.43%   50.90%   -1.53%     
   + Complexity     5245     5240       -5     
   ============================================
     Files           924      931       +7     
     Lines         32066    32993     +927     
     Branches       3833     3996     +163     
   ============================================
   - Hits          16813    16795      -18     
   - Misses        13598    14542     +944     
   - Partials       1655     1656       +1     
   ```
   
   
   | [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...aga/engine/expression/spel/SpringELExpression.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvZXhwcmVzc2lvbi9zcGVsL1NwcmluZ0VMRXhwcmVzc2lvbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [.../engine/invoker/impl/SpringBeanServiceInvoker.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvaW52b2tlci9pbXBsL1NwcmluZ0JlYW5TZXJ2aWNlSW52b2tlci5qYXZh) | `0.00% <ø> (ø)` | |
   | [...ga/engine/store/db/DbAndReportTcStateLogStore.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvc3RvcmUvZGIvRGJBbmRSZXBvcnRUY1N0YXRlTG9nU3RvcmUuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...g/apache/seata/saga/engine/utils/ResourceUtil.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvdXRpbHMvUmVzb3VyY2VVdGlsLmphdmE=) | `66.66% <100.00%> (ø)` | |
   | [...ser/impl/CompensateSubStateMachineStateParser.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXN0YXRlbGFuZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9zdGF0ZWxhbmcvcGFyc2VyL2ltcGwvQ29tcGVuc2F0ZVN1YlN0YXRlTWFjaGluZVN0YXRlUGFyc2VyLmphdmE=) | `66.66% <ø> (ø)` | |
   | [...a/statelang/parser/impl/SubStateMachineParser.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXN0YXRlbGFuZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9zdGF0ZWxhbmcvcGFyc2VyL2ltcGwvU3ViU3RhdGVNYWNoaW5lUGFyc2VyLmphdmE=) | `90.90% <ø> (ø)` | |
   | [...tatelang/parser/utils/DesignerJsonTransformer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXN0YXRlbGFuZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9zdGF0ZWxhbmcvcGFyc2VyL3V0aWxzL0Rlc2lnbmVySnNvblRyYW5zZm9ybWVyLmphdmE=) | `54.65% <ø> (ø)` | |
   | [...boot/autoconfigure/SeataSagaAutoConfiguration.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VhdGEtc3ByaW5nLWJvb3Qtc3RhcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc3ByaW5nL2Jvb3QvYXV0b2NvbmZpZ3VyZS9TZWF0YVNhZ2FBdXRvQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ga/engine/tm/DefaultSagaTransactionalTemplate.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvdG0vRGVmYXVsdFNhZ2FUcmFuc2FjdGlvbmFsVGVtcGxhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ine/expression/spel/SpringELExpressionFactory.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvZXhwcmVzc2lvbi9zcGVsL1NwcmluZ0VMRXhwcmVzc2lvbkZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [3 more](https://app.codecov.io/gh/apache/incubator-seata/pull/6370?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6370/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] feature: saga-remove spring [incubator-seata]

Posted by "wt-better (via GitHub)" <gi...@apache.org>.
wt-better commented on PR #6370:
URL: https://github.com/apache/incubator-seata/pull/6370#issuecomment-1970489070

   > code style need change
   
   i think not need change, history layout is not standard.
   
   standard layout
   ![image](https://github.com/apache/incubator-seata/assets/26296600/9e5fa742-c9d2-4231-a1d5-1513f8657915)
   
   seata-core  etc ..  other moudle also keep this layout


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] feature: saga-remove spring [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6370:
URL: https://github.com/apache/incubator-seata/pull/6370#discussion_r1503889074


##########
saga/seata-saga-engine/src/main/java/org/apache/seata/saga/engine/pcext/handlers/ServiceTaskStateHandler.java:
##########
@@ -43,8 +39,11 @@
 import org.apache.seata.saga.statelang.domain.impl.ServiceTaskStateImpl;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.context.ApplicationContextAware;
-import org.springframework.util.StringUtils;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;

Review Comment:
   ```suggestion
   
   ```



##########
saga/seata-saga-engine/src/main/java/org/apache/seata/saga/engine/pcext/handlers/ServiceTaskStateHandler.java:
##########
@@ -16,13 +16,9 @@
  */
 package org.apache.seata.saga.engine.pcext.handlers;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-
 import org.apache.seata.common.exception.FrameworkErrorCode;

Review Comment:
   ```suggestion
   import java.util.ArrayList;
   import java.util.HashMap;
   import java.util.List;
   import java.util.Map;
   
   import org.apache.seata.common.exception.FrameworkErrorCode;
   ```



##########
saga/seata-saga-spring/src/main/java/org/apache/seata/saga/engine/config/DbStateMachineConfig.java:
##########
@@ -16,34 +16,35 @@
  */
 package org.apache.seata.saga.engine.config;
 
-import javax.sql.DataSource;
-import java.sql.Connection;
-import java.sql.DatabaseMetaData;
-import java.sql.SQLException;
-
+import org.apache.seata.common.ConfigurationKeys;
 import org.apache.seata.config.Configuration;
 import org.apache.seata.config.ConfigurationFactory;
-import org.apache.seata.core.constants.ConfigurationKeys;
 import org.apache.seata.saga.engine.impl.DefaultStateMachineConfig;
 import org.apache.seata.saga.engine.serializer.impl.ParamsSerializer;
 import org.apache.seata.saga.engine.store.db.DbAndReportTcStateLogStore;
 import org.apache.seata.saga.engine.store.db.DbStateLangStore;
-import org.apache.seata.saga.tm.DefaultSagaTransactionalTemplate;
-import org.apache.seata.saga.tm.SagaTransactionalTemplate;
+import org.apache.seata.saga.engine.tm.DefaultSagaTransactionalTemplate;
+import org.apache.seata.saga.engine.tm.SagaTransactionalTemplate;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.DisposableBean;
 import org.springframework.util.StringUtils;
 
+import javax.sql.DataSource;
+import java.sql.Connection;
+import java.sql.DatabaseMetaData;
+import java.sql.SQLException;

Review Comment:
   ```suggestion
   ```



##########
saga/seata-saga-engine/src/main/java/org/apache/seata/saga/engine/pcext/interceptors/ServiceTaskHandlerInterceptor.java:
##########
@@ -16,20 +16,16 @@
  */
 package org.apache.seata.saga.engine.pcext.interceptors;
 
-import java.util.Date;
-import java.util.LinkedHashMap;
-import java.util.List;
-import java.util.Map;
-
 import org.apache.seata.common.exception.FrameworkErrorCode;

Review Comment:
   ```suggestion
   import java.util.Date;
   import java.util.LinkedHashMap;
   import java.util.List;
   import java.util.Map;
   
   import org.apache.seata.common.exception.FrameworkErrorCode;
   ```



##########
saga/seata-saga-spring/src/main/java/org/apache/seata/saga/engine/config/DbStateMachineConfig.java:
##########
@@ -16,34 +16,35 @@
  */
 package org.apache.seata.saga.engine.config;
 
-import javax.sql.DataSource;
-import java.sql.Connection;
-import java.sql.DatabaseMetaData;
-import java.sql.SQLException;
-
+import org.apache.seata.common.ConfigurationKeys;

Review Comment:
   ```suggestion
   import javax.sql.DataSource;
   import java.sql.Connection;
   import java.sql.DatabaseMetaData;
   import java.sql.SQLException;
   
   import org.apache.seata.common.ConfigurationKeys;
   ```



##########
saga/seata-saga-statelang/src/test/java/org/apache/seata/saga/statelang/parser/StateParserTests.java:
##########
@@ -16,29 +16,27 @@
  */
 package org.apache.seata.saga.statelang.parser;
 
-import java.io.IOException;
-import java.util.Date;
-import java.util.Map;
-
 import org.apache.seata.saga.statelang.domain.StateMachine;
 import org.apache.seata.saga.statelang.parser.utils.DesignerJsonTransformer;
-import org.apache.seata.saga.statelang.validator.ValidationException;
 import org.apache.seata.saga.statelang.parser.utils.IOUtils;
+import org.apache.seata.saga.statelang.validator.ValidationException;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
-import org.springframework.core.io.ClassPathResource;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Date;
+import java.util.Map;

Review Comment:
   ```suggestion
   ```



##########
saga/seata-saga-engine/src/main/java/org/apache/seata/saga/engine/pcext/handlers/SubStateMachineHandler.java:
##########
@@ -41,7 +37,11 @@
 import org.apache.seata.saga.statelang.domain.impl.SubStateMachineImpl;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.util.StringUtils;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;

Review Comment:
   ```suggestion
   
   ```



##########
saga/seata-saga-engine/src/main/java/org/apache/seata/saga/engine/pcext/handlers/SubStateMachineHandler.java:
##########
@@ -16,12 +16,8 @@
  */
 package org.apache.seata.saga.engine.pcext.handlers;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-
 import org.apache.seata.common.exception.FrameworkErrorCode;

Review Comment:
   ```suggestion
   import java.util.ArrayList;
   import java.util.HashMap;
   import java.util.List;
   import java.util.Map;
   
   import org.apache.seata.common.exception.FrameworkErrorCode;
   ```



##########
saga/seata-saga-spring/src/main/java/org/apache/seata/saga/engine/impl/DefaultStateMachineConfig.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.seata.saga.engine.impl;
+
+import org.apache.seata.saga.engine.config.AbstractStateMachineConfig;
+import org.apache.seata.saga.engine.expression.ExpressionFactoryManager;
+import org.apache.seata.saga.engine.expression.spel.SpringELExpressionFactory;
+import org.apache.seata.saga.engine.invoker.ServiceInvokerManager;
+import org.apache.seata.saga.engine.invoker.impl.SpringBeanServiceInvoker;
+import org.apache.seata.saga.engine.utils.ResourceUtil;
+import org.apache.seata.saga.statelang.domain.DomainConstants;
+import org.springframework.beans.factory.InitializingBean;
+import org.springframework.context.ApplicationContext;
+import org.springframework.context.ApplicationContextAware;
+import org.springframework.core.io.Resource;
+
+import java.io.IOException;
+import java.io.InputStream;

Review Comment:
   ```suggestion
   ```



##########
saga/seata-saga-engine/src/main/java/org/apache/seata/saga/engine/impl/ProcessCtrlStateMachineEngine.java:
##########
@@ -16,14 +16,9 @@
  */
 package org.apache.seata.saga.engine.impl;
 
-import java.util.Date;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
-
 import org.apache.seata.common.exception.FrameworkErrorCode;

Review Comment:
   ```suggestion
   import java.util.Date;
   import java.util.HashMap;
   import java.util.List;
   import java.util.Map;
   import java.util.concurrent.ConcurrentHashMap;
   
   import org.apache.seata.common.exception.FrameworkErrorCode;
   ```



##########
saga/seata-saga-engine/src/main/java/org/apache/seata/saga/engine/pcext/interceptors/ServiceTaskHandlerInterceptor.java:
##########
@@ -48,9 +44,14 @@
 import org.apache.seata.saga.statelang.domain.StateMachineInstance;
 import org.apache.seata.saga.statelang.domain.impl.ServiceTaskStateImpl;
 import org.apache.seata.saga.statelang.domain.impl.StateInstanceImpl;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.util.StringUtils;
+
+import java.util.Date;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;

Review Comment:
   ```suggestion
   
   ```



##########
saga/seata-saga-spring/src/main/java/org/apache/seata/saga/engine/impl/DefaultStateMachineConfig.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.seata.saga.engine.impl;
+
+import org.apache.seata.saga.engine.config.AbstractStateMachineConfig;

Review Comment:
   ```suggestion
   import java.io.IOException;
   import java.io.InputStream;
   
   import org.apache.seata.saga.engine.config.AbstractStateMachineConfig;
   ```



##########
saga/seata-saga-statelang/src/test/java/org/apache/seata/saga/statelang/parser/StateParserTests.java:
##########
@@ -16,29 +16,27 @@
  */
 package org.apache.seata.saga.statelang.parser;
 

Review Comment:
   ```suggestion
   
   import java.io.IOException;
   import java.io.InputStream;
   import java.util.Date;
   import java.util.Map;
   ```



##########
saga/seata-saga-engine/src/main/java/org/apache/seata/saga/engine/impl/ProcessCtrlStateMachineEngine.java:
##########
@@ -48,9 +43,15 @@
 import org.apache.seata.saga.statelang.domain.impl.LoopStartStateImpl;
 import org.apache.seata.saga.statelang.domain.impl.ServiceTaskStateImpl;
 import org.apache.seata.saga.statelang.domain.impl.StateMachineInstanceImpl;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.util.StringUtils;
+
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org