You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/01/21 15:12:50 UTC
[kudu-CR] [python] Use positional formatting in Python scripts
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15075
Change subject: [python] Use positional formatting in Python scripts
......................................................................
[python] Use positional formatting in Python scripts
get-job-stats-from-mysql.py is not compatible with Python 2.6.x
beause it uses the format function without the positions included.
I also updated other calls to format without explicit positions.
Change-Id: I0eb17a5b0435e8e78a31124c8d9f3756583cd05a
---
M build-support/iwyu/iwyu_tool.py
M src/kudu/experiments/merge-test.py
M src/kudu/scripts/get-job-stats-from-mysql.py
M src/kudu/scripts/max_skew_estimate.py
4 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/15075/1
--
To view, visit http://gerrit.cloudera.org:8080/15075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0eb17a5b0435e8e78a31124c8d9f3756583cd05a
Gerrit-Change-Number: 15075
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [python] Use positional formatting in Python scripts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15075 )
Change subject: [python] Use positional formatting in Python scripts
......................................................................
[python] Use positional formatting in Python scripts
get-job-stats-from-mysql.py is not compatible with Python 2.6.x
beause it uses the format function without the positions included.
I also updated other calls to format without explicit positions.
Change-Id: I0eb17a5b0435e8e78a31124c8d9f3756583cd05a
Reviewed-on: http://gerrit.cloudera.org:8080/15075
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
M build-support/iwyu/iwyu_tool.py
M src/kudu/experiments/merge-test.py
M src/kudu/scripts/get-job-stats-from-mysql.py
M src/kudu/scripts/graph-metrics.py
M src/kudu/scripts/max_skew_estimate.py
5 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
Bankim Bhavsar: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/15075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0eb17a5b0435e8e78a31124c8d9f3756583cd05a
Gerrit-Change-Number: 15075
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] Use positional formatting in Python scripts
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15075 )
Change subject: [python] Use positional formatting in Python scripts
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eb17a5b0435e8e78a31124c8d9f3756583cd05a
Gerrit-Change-Number: 15075
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 21 Jan 2020 18:44:21 +0000
Gerrit-HasComments: No
[kudu-CR] [python] Use positional formatting in Python scripts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15075
to look at the new patch set (#2).
Change subject: [python] Use positional formatting in Python scripts
......................................................................
[python] Use positional formatting in Python scripts
get-job-stats-from-mysql.py is not compatible with Python 2.6.x
beause it uses the format function without the positions included.
I also updated other calls to format without explicit positions.
Change-Id: I0eb17a5b0435e8e78a31124c8d9f3756583cd05a
---
M build-support/iwyu/iwyu_tool.py
M src/kudu/experiments/merge-test.py
M src/kudu/scripts/get-job-stats-from-mysql.py
M src/kudu/scripts/graph-metrics.py
M src/kudu/scripts/max_skew_estimate.py
5 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/15075/2
--
To view, visit http://gerrit.cloudera.org:8080/15075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0eb17a5b0435e8e78a31124c8d9f3756583cd05a
Gerrit-Change-Number: 15075
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] Use positional formatting in Python scripts
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15075 )
Change subject: [python] Use positional formatting in Python scripts
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15075/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15075/2//COMMIT_MSG@10
PS2, Line 10: beause
typo
--
To view, visit http://gerrit.cloudera.org:8080/15075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eb17a5b0435e8e78a31124c8d9f3756583cd05a
Gerrit-Change-Number: 15075
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 21 Jan 2020 18:44:28 +0000
Gerrit-HasComments: Yes