You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/11/10 22:25:18 UTC
Review Request 40153: Finalize Upgrade Pre-Check is not retryable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40153/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.
Bugs: AMBARI-13822
https://issues.apache.org/jira/browse/AMBARI-13822
Repository: ambari
Description
-------
The Finalize Pre-Check should return FAILED on failure, instead of HOLDING. This will give the option to Retry after fixing issues.
Also added supports-auto-skip-failure element to that group to ensure FAILED doesn't get skipped. Also set that element on CORE_MASTERS since core-masters can't be auto-skipped.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java 39175c9
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3c32a81
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 9caf300
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b8bf32a
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f4ad9e3
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8173535
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ae5747a
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 676039c
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java ea0cf45
Diff: https://reviews.apache.org/r/40153/diff/
Testing
-------
Manual on live upgrade. Automated pending.
Thanks,
Nate Cole
Re: Review Request 40153: Finalize Upgrade Pre-Check is not retryable
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40153/#review105983
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Nov. 10, 2015, 10:27 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40153/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 10:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.
>
>
> Bugs: AMBARI-13822
> https://issues.apache.org/jira/browse/AMBARI-13822
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Finalize Pre-Check should return FAILED on failure, instead of HOLDING. This will give the option to Retry after fixing issues.
>
> Also added supports-auto-skip-failure element to that group to ensure FAILED doesn't get skipped. Also set that element on CORE_MASTERS since core-masters can't be auto-skipped.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java 39175c9
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3c32a81
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 9caf300
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b8bf32a
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f4ad9e3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8173535
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ae5747a
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 676039c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java ea0cf45
>
> Diff: https://reviews.apache.org/r/40153/diff/
>
>
> Testing
> -------
>
> Manual on live upgrade. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 40153: Finalize Upgrade Pre-Check is not retryable
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40153/
-----------------------------------------------------------
(Updated Nov. 10, 2015, 5:27 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.
Changes
-------
Updated diff for fixes I didn't know about :)
Bugs: AMBARI-13822
https://issues.apache.org/jira/browse/AMBARI-13822
Repository: ambari
Description
-------
The Finalize Pre-Check should return FAILED on failure, instead of HOLDING. This will give the option to Retry after fixing issues.
Also added supports-auto-skip-failure element to that group to ensure FAILED doesn't get skipped. Also set that element on CORE_MASTERS since core-masters can't be auto-skipped.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java 39175c9
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3c32a81
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 9caf300
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b8bf32a
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f4ad9e3
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8173535
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ae5747a
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 676039c
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java ea0cf45
Diff: https://reviews.apache.org/r/40153/diff/
Testing
-------
Manual on live upgrade. Automated pending.
Thanks,
Nate Cole
Re: Review Request 40153: Finalize Upgrade Pre-Check is not retryable
Posted by Nate Cole <nc...@hortonworks.com>.
> On Nov. 10, 2015, 5:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml, lines 490-492
> > <https://reviews.apache.org/r/40153/diff/1/?file=1122450#file1122450line490>
> >
> > Latest patch allows you to not have to set `supports-auto-skip-failure` if `skippable` is false. If both are false, they actually don't need to specified at all.
Sweet! Makes the patch much simpler with that fix. Thanks
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40153/#review105970
-----------------------------------------------------------
On Nov. 10, 2015, 5:27 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40153/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 5:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.
>
>
> Bugs: AMBARI-13822
> https://issues.apache.org/jira/browse/AMBARI-13822
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Finalize Pre-Check should return FAILED on failure, instead of HOLDING. This will give the option to Retry after fixing issues.
>
> Also added supports-auto-skip-failure element to that group to ensure FAILED doesn't get skipped. Also set that element on CORE_MASTERS since core-masters can't be auto-skipped.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java 39175c9
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3c32a81
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 9caf300
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b8bf32a
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f4ad9e3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8173535
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ae5747a
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 676039c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java ea0cf45
>
> Diff: https://reviews.apache.org/r/40153/diff/
>
>
> Testing
> -------
>
> Manual on live upgrade. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 40153: Finalize Upgrade Pre-Check is not retryable
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40153/#review105970
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (lines 490 - 492)
<https://reviews.apache.org/r/40153/#comment164669>
Latest patch allows you to not have to set `supports-auto-skip-failure` if `skippable` is false. If both are false, they actually don't need to specified at all.
- Jonathan Hurley
On Nov. 10, 2015, 4:25 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40153/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 4:25 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.
>
>
> Bugs: AMBARI-13822
> https://issues.apache.org/jira/browse/AMBARI-13822
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Finalize Pre-Check should return FAILED on failure, instead of HOLDING. This will give the option to Retry after fixing issues.
>
> Also added supports-auto-skip-failure element to that group to ensure FAILED doesn't get skipped. Also set that element on CORE_MASTERS since core-masters can't be auto-skipped.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java 39175c9
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3c32a81
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 9caf300
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b8bf32a
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f4ad9e3
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8173535
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ae5747a
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 676039c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java ea0cf45
>
> Diff: https://reviews.apache.org/r/40153/diff/
>
>
> Testing
> -------
>
> Manual on live upgrade. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>