[jira] [Commented] (SLING-8800) A change in a Content Package will not be reflected in a Converted CP on a rebuild

["Andreas Schaefer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-8800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983077#comment-16983077 ] 

Andreas Schaefer commented on SLING-8800:
-----------------------------------------

I merged my PR as this was pending after a month and I discovered another issue where when two modules in a project have the same artifact id like ui.apps (but different group ids) then the deflated folder would contain both code as the folders are not deleted.
I fixed that by adding the package id as a prefix to the file name - hopefully this makes the folder unique. Anyhow the deletion of the folder would prevent the code duplication.

> A change in a Content Package will not be reflected in a Converted CP on a rebuild
> ----------------------------------------------------------------------------------
>
>                 Key: SLING-8800
>                 URL: https://issues.apache.org/jira/browse/SLING-8800
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>            Reporter: Andreas Schaefer
>            Assignee: Simone Tripodi
>            Priority: Major
>             Fix For: Content-Package to Feature Model Converter 1.0.0
>
>         Attachments: secondary-test.zip
>
>
> After a successful content package conversion any change in a content package will not be reflected in a converted content package.
> The reason is that the temporary generated file inside a temporary folder created in the VaultPackageAssembler is not deleted.
> The CP Converter should at least provide a flag to force the deletion but maybe it is best to use a hash to see if the content has changed and if should delete the temporary folder.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)