[GitHub] [spark] LuciferYang commented on pull request #39789: [SPARK-42228][BUILD][CONNECT] Add shade and relocation rule of grpc to connect-client-jvm module

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on PR #39789:
URL: https://github.com/apache/spark/pull/39789#issuecomment-1411259857

   > @LuciferYang I checked with the maven jar, and I found the io.grpc is still not shaded? And then the guava is shaded twice. Can you double check?
   > 
   > ```
   > jar -tf <path/to/client.jar>
   > ```
   > 
   > To fix the maven jar, I need the following changes on top of your PR:
   > 
   > ```
   > --- a/connector/connect/client/jvm/pom.xml
   > +++ b/connector/connect/client/jvm/pom.xml
   > @@ -105,7 +105,7 @@
   >            <artifactSet>
   >              <includes>
   >                <include>com.google.guava:*</include>
   > -              <include>io.grpc:*:</include>
   > +              <include>io.grpc:*</include>
   >                <include>com.google.protobuf:*</include>
   >                <include>org.apache.spark:spark-connect-common_${scala.binary.version}</include>
   >              </includes>
   > @@ -114,6 +114,9 @@
   >              <relocation>
   >                <pattern>io.grpc</pattern>
   >                <shadedPattern>${spark.shade.packageName}.connect.grpc</shadedPattern>
   > +              <includes>
   > +                <include>io.grpc.**</include>
   > +              </includes>
   >              </relocation>
   >              <relocation>
   >                <pattern>com.google.protobuf</pattern>
   > @@ -124,14 +127,14 @@
   >              </relocation>
   >              <relocation>
   >                <pattern>com.google.common</pattern>
   > -              <shadedPattern>${spark.shade.packageName}.connect.client.guava</shadedPattern>
   > +              <shadedPattern>${spark.shade.packageName}.connect.guava</shadedPattern>
   >                <includes>
   >                  <include>com.google.common.**</include>
   >                </includes>
   >              </relocation>
   >              <relocation>
   >                <pattern>com.google.thirdparty</pattern>
   > -              <shadedPattern>${spark.shade.packageName}.connect.client.guava</shadedPattern>
   > +              <shadedPattern>${spark.shade.packageName}.connect.guava</shadedPattern>
   >                <includes>
   >                  <include>com.google.thirdparty.**</include>
   >                </includes>
   > ```
   
   Thanks for your review @zhenlineo , let me double check this today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org