You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@archiva.apache.org by Brett Porter <br...@apache.org> on 2007/12/27 13:14:46 UTC
dependency on archiva-configuration -> archiva-model in r602916 for legacy paths
Hi Nicolas,
I saw this added dependency in one of your commits and thought it
might be best kept separated - do you think the toArtifactReference()
might be better suited to being in the LegacyPathParser?
Cheers,
Brett
Re: dependency on archiva-configuration -> archiva-model in r602916 for legacy paths
Posted by nicolas de loof <ni...@apache.org>.
I'll look to refactor this next week.
cheers,
Nico.
2007/12/27, Brett Porter <br...@apache.org>:
>
>
> On 28/12/2007, at 5:05 AM, nicolas de loof wrote:
>
> > Just wanted to have LegacyArtifactPath hide the String
> > representation used
> > in storage, but project dependencies is also valuable.
>
> Your reasoning makes sense :)
>
> >
> >
> > Why shouldn't archiva-configuration depend on achiva-model ? IMHO, the
> > "model" should have no dependency. But you can make any change
> > required for
> > better architecture.
>
> That's why I was saying it - configuration is a model also and so I
> was trying to avoid a dependency (note that archiva-model drags in JDO
> among other things - though this is really a problem with archiva-
> model...). I was also trying to avoid code in the configuration class
> where possible - but your reason made sense.
>
> It's not a big deal - just something to think about :)
>
> Cheers,
> Brett
>
>
Re: dependency on archiva-configuration -> archiva-model in r602916 for legacy paths
Posted by Brett Porter <br...@apache.org>.
On 28/12/2007, at 5:05 AM, nicolas de loof wrote:
> Just wanted to have LegacyArtifactPath hide the String
> representation used
> in storage, but project dependencies is also valuable.
Your reasoning makes sense :)
>
>
> Why shouldn't archiva-configuration depend on achiva-model ? IMHO, the
> "model" should have no dependency. But you can make any change
> required for
> better architecture.
That's why I was saying it - configuration is a model also and so I
was trying to avoid a dependency (note that archiva-model drags in JDO
among other things - though this is really a problem with archiva-
model...). I was also trying to avoid code in the configuration class
where possible - but your reason made sense.
It's not a big deal - just something to think about :)
Cheers,
Brett
Re: dependency on archiva-configuration -> archiva-model in r602916 for legacy paths
Posted by nicolas de loof <ni...@apache.org>.
Just wanted to have LegacyArtifactPath hide the String representation used
in storage, but project dependencies is also valuable.
Why shouldn't archiva-configuration depend on achiva-model ? IMHO, the
"model" should have no dependency. But you can make any change required for
better architecture.
Nico.
2007/12/27, Brett Porter <br...@apache.org>:
>
> Hi Nicolas,
>
> I saw this added dependency in one of your commits and thought it
> might be best kept separated - do you think the toArtifactReference()
> might be better suited to being in the LegacyPathParser?
>
> Cheers,
> Brett
>