Re: [DISCUSS] Enable GitHub pull request notification (Was: Re: GitHub pull requests (Was: Re: Github integration))

[Noah Slater <ns...@apache.org>]

Okay, I believe consensus was established.

You can track this request here:

https://issues.apache.org/jira/browse/INFRA-6225

Chip, I've been privy to lots of conversations about this issue you bring
up. Across quite a few foundation lists, it seems that the general feeling
is that it should be clear to most people that the canonical repository is
the one hosted at the ASF. Of course, if that isn't the case, and we run
into problems, then we should re-evaluate our GitHub integration.


On 27 April 2013 19:57, Chip Childers <ch...@sungard.com> wrote:

> On Apr 27, 2013, at 2:55 PM, David Nalley <da...@gnsa.us> wrote:
>
> > On Sat, Apr 27, 2013 at 12:35 PM, Noah Slater <ns...@apache.org>
> wrote:
> >> Devs,
> >>
> >> I would like to propose that we turn on notifications for pull requests
> >> that are made via GitHub. This will ensure that PRs are not "lost
> between
> >> the cracks". I believe this integration is already available, and we
> just
> >> need to request it.
> >>
> >> You do not need to respond if you are in agreement. If there is no
> response
> >> in 72 hours, I will assume lazy consensus.
> >>
> >> If we reach consensus, I will start the corresponding [VOTE] thread and
> >> complete the rest of process.
> >>
> >> (Please note that when I brought this up originally, the idea had a +1
> from
> >> Prasanna and Rohit. But I do not believe I stated lazy consensus  So I
> am
> >> doing this a second time, properly. Sorry about that folks!)
> >>
> >> Thanks,
> >
> >
> > I think, but am not sure, that after the first PR against a github
> > repo that infra@ sets up forwarding rules so they end up on dev@. (I
> > do lots of infra git work, but not github work). That said, I see
> > there has been one, but I don't recall that coming to dev@ [1].
> > Regardless, my opinion is that there really isn't an option - if we
> > are going to have a github mirror, we also need to be able to deal
> > with the pull requests there. Ignoring folks that submit pull requests
> > is inappropriate.
>
> Agreed, but frankly I'd consider not having a github mirror. Not sure
> the value, when you consider the confusion it causes WRT the canonical
> source repo.
>
> >
> > [1] https://github.com/apache/incubator-cloudstack/pull/1
> >
> > --David
> >
>



-- 
NS

Re: [DISCUSS] Enable GitHub pull request notification (Was: Re: GitHub pull requests (Was: Re: Github integration))

[Chip Childers <ch...@sungard.com>]

On Fri, May 03, 2013 at 03:13:05PM +0100, Noah Slater wrote:
> Okay, I believe consensus was established.
> 
> You can track this request here:
> 
> https://issues.apache.org/jira/browse/INFRA-6225
> 
> Chip, I've been privy to lots of conversations about this issue you bring
> up. Across quite a few foundation lists, it seems that the general feeling
> is that it should be clear to most people that the canonical repository is
> the one hosted at the ASF. Of course, if that isn't the case, and we run
> into problems, then we should re-evaluate our GitHub integration.

Well, we've run into this in our project.  It's really only an issue
when the replication sync breaks (or is broken like it is now).  I guess
we can live with it and handle issues as they come up.

-chip