[GitHub] [camel-k] nicolaferraro commented on a change in pull request #2355: feat(cmd/run): resource option refactoring

[GitBox <gi...@apache.org>]

nicolaferraro commented on a change in pull request #2355:
URL: https://github.com/apache/camel-k/pull/2355#discussion_r650792506



##########
File path: pkg/trait/util.go
##########
@@ -76,6 +76,36 @@ func collectConfigurationValues(configurationType string, configurable ...v1.Con
 	return s
 }
 
+func collectConfigurations(configurationType string, configurable ...v1.Configurable) []map[string]string {
+	var result []map[string]string
+
+	for _, c := range configurable {
+		c := c
+
+		if c == nil || reflect.ValueOf(c).IsNil() {
+			continue
+		}
+
+		entries := c.Configurations()
+		if entries == nil {
+			continue
+		}
+
+		for _, entry := range entries {
+			if entry.Type == configurationType {
+				var item = make(map[string]string)

Review comment:
       Probably you could have used the entry struct type instead of map, but it's ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org