[jira] [Commented] (FLUME-1513) File Channel log close() method should not be synchronized

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442858#comment-13442858 ] 

Hudson commented on FLUME-1513:
-------------------------------

Integrated in flume-trunk #290 (See [https://builds.apache.org/job/flume-trunk/290/])
    FLUME-1513: File Channel log close() method should not be synchronized (Revision 0dba90a42b8eb672d58e862fad8c498f71831717)

     Result = SUCCESS
brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git;a=summary&a=commit&h=0dba90a42b8eb672d58e862fad8c498f71831717
Files : 
* flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java

                
> File Channel log close() method should not be synchronized
> ----------------------------------------------------------
>
>                 Key: FLUME-1513
>                 URL: https://issues.apache.org/jira/browse/FLUME-1513
>             Project: Flume
>          Issue Type: Bug
>    Affects Versions: v1.3.0
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>             Fix For: v1.3.0
>
>         Attachments: FLUME-1513.patch
>
>
> This can cause a deadlock similar to the one fixed in FLUME-1327. If a put/commit gets the read lock and close() from another thread is called before roll(), then it will lead to a deadlock(since close is waiting on the write lock and roll will be blocked on the monitor which is held by the thread calling close()). This will happen only much less frequently than FLUME-1327, since the close method is called only when the channel is getting stopped.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira