You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by dasahcc <gi...@git.apache.org> on 2017/02/09 19:44:21 UTC
[GitHub] helix pull request #71: [HELIX-653] Fix enable/disable partition in instance...
GitHub user dasahcc opened a pull request:
https://github.com/apache/helix/pull/71
[HELIX-653] Fix enable/disable partition in instances for resource specific
Helix currently enable/disable partition in instances across all the resources if partition is same. Fix it with resource associated partition enable/disable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dasahcc/helix helix-0.6.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit befcc65c2e67df9767ab5d2eca837339894c5581
Author: Junkai Xue <jx...@linkedin.com>
Date: 2017-02-09T19:36:32Z
[HELIX-653] Fix enable/disable partition in instances for resource specific
Helix currently enable/disable partition in instances across all the resources if partition is same. Fix it with resource associated partition enable/disable.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request #71: [HELIX-653] Fix enable/disable partition in instance...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/helix/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request #71: [HELIX-653] Fix enable/disable partition in instance...
Posted by lei-xia <gi...@git.apache.org>.
Github user lei-xia commented on a diff in the pull request:
https://github.com/apache/helix/pull/71#discussion_r100397892
--- Diff: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java ---
@@ -68,6 +71,17 @@ public static String getZkName(String path) {
return path.substring(path.lastIndexOf('/') + 1);
}
+ public static String serializeByComma(List<String> objects) {
+ return String.join(",", objects);
--- End diff --
Got a compile error here since this is JAVA 8 lib. Can you fix it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---