[GitHub] [spark] dongjoon-hyun commented on pull request #43038: [SPARK-45261][CORE] Fix `EventLogFileWriters` to handle `none` as a codec

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on PR #43038:
URL: https://github.com/apache/spark/pull/43038#issuecomment-1730299378

   I manually test this.
   ```
   $ build/sbt "core/testOnly *EventLogFile*ReaderSuite*"
   ...
   [info] RollingEventLogFilesReaderSuite:
   [info] - Retrieve EventLogFileReader correctly (96 milliseconds)
   [info] - get information, list event log files, zip log files - with codec None (80 milliseconds)
   [info] - get information, list event log files, zip log files - with codec Some(lz4) (109 milliseconds)
   [info] - get information, list event log files, zip log files - with codec Some(lzf) (44 milliseconds)
   [info] - get information, list event log files, zip log files - with codec Some(snappy) (96 milliseconds)
   [info] - get information, list event log files, zip log files - with codec Some(zstd) (145 milliseconds)
   [info] - rolling event log files - codec None (394 milliseconds)
   [info] - rolling event log files - codec Some(lz4) (91 milliseconds)
   [info] - rolling event log files - codec Some(lzf) (105 milliseconds)
   [info] - rolling event log files - codec Some(snappy) (117 milliseconds)
   [info] - rolling event log files - codec Some(zstd) (86 milliseconds)
   [info] SingleFileEventLogFileReaderSuite:
   [info] - Retrieve EventLogFileReader correctly (66 milliseconds)
   [info] - get information, list event log files, zip log files - with codec None (14 milliseconds)
   [info] - get information, list event log files, zip log files - with codec Some(lz4) (13 milliseconds)
   [info] - get information, list event log files, zip log files - with codec Some(lzf) (12 milliseconds)
   [info] - get information, list event log files, zip log files - with codec Some(snappy) (12 milliseconds)
   [info] - get information, list event log files, zip log files - with codec Some(zstd) (11 milliseconds)
   [info] Run completed in 2 seconds, 501 milliseconds.
   [info] Total number of tests run: 17
   [info] Suites: completed 2, aborted 0
   [info] Tests: succeeded 17, failed 0, canceled 0, ignored 0, pending 0
   [info] All tests passed.
   [success] Total time: 29 s, completed Sep 21, 2023, 2:03:02 PM
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org