You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2023/04/05 14:32:37 UTC
[kudu-CR] [build] Fix build issue on MacOS
Hello Zoltan Chovan,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19692
to review the following change.
Change subject: [build] Fix build issue on MacOS
......................................................................
[build] Fix build issue on MacOS
Building Kudu on MacOS was failing due to a linking issue. Specifically,
BIO_* functions weren't reachable from jwt_test_certs. It's unclear to
me how exactly it worked on Linux, I suspect the linker picks up OpenSSL
libraries automatically on Linux. Anyway, this commit fix the build by
adding the correct dependencies to jwt_test_certs.
Change-Id: Ifded17faafe99d8bbb896dc65298a8bd4c38854f
---
M src/kudu/util/CMakeLists.txt
1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/19692/1
--
To view, visit http://gerrit.cloudera.org:8080/19692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifded17faafe99d8bbb896dc65298a8bd4c38854f
Gerrit-Change-Number: 19692
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [build] Fix build issue on MacOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19692 )
Change subject: [build] Fix build issue on MacOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifded17faafe99d8bbb896dc65298a8bd4c38854f
Gerrit-Change-Number: 19692
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 02:15:15 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fix build issue on MacOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19692 )
Change subject: [build] Fix build issue on MacOS
......................................................................
[build] Fix build issue on MacOS
Building Kudu on MacOS was failing due to a linking issue. Specifically,
BIO_* functions weren't reachable from jwt_test_certs. It's unclear to
me how exactly it worked on Linux, I suspect the linker picks up OpenSSL
libraries automatically on Linux. Anyway, this commit fix the build by
adding the correct dependencies to jwt_test_certs.
Change-Id: Ifded17faafe99d8bbb896dc65298a8bd4c38854f
Reviewed-on: http://gerrit.cloudera.org:8080/19692
Tested-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/util/CMakeLists.txt
1 file changed, 7 insertions(+), 6 deletions(-)
Approvals:
Attila Bukor: Verified
Marton Greber: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifded17faafe99d8bbb896dc65298a8bd4c38854f
Gerrit-Change-Number: 19692
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [build] Fix build issue on MacOS
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19692 )
Change subject: [build] Fix build issue on MacOS
......................................................................
Patch Set 1: Code-Review+1
Tested it on my M1 mac: without this patch the build fails, after applying this patch, the build goes through successfully.
Thanks for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/19692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifded17faafe99d8bbb896dc65298a8bd4c38854f
Gerrit-Change-Number: 19692
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 15:18:08 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fix build issue on MacOS
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: [build] Fix build issue on MacOS
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifded17faafe99d8bbb896dc65298a8bd4c38854f
Gerrit-Change-Number: 19692
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [build] Fix build issue on MacOS
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19692 )
Change subject: [build] Fix build issue on MacOS
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifded17faafe99d8bbb896dc65298a8bd4c38854f
Gerrit-Change-Number: 19692
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 15:12:14 +0000
Gerrit-HasComments: No