You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/12/23 02:09:44 UTC
Review Request 55006: CMake: renamed test binaries to match autotools.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55006/
-----------------------------------------------------------
Review request for mesos, Alex Clemmer and Joseph Wu.
Repository: mesos
Description
-------
Currently CMake generates test binaries named `stout_tests`,
`process_tests` (underscores), and `mesos-tests` (dash).
We should simply follow the naming from autotools and call them
`stout-tests`, `libprocess-tests`, and `mesos-tests`.
Diffs
-----
src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c
Diff: https://reviews.apache.org/r/55006/diff/
Testing
-------
`cmake --build . -- -j 6`
```
$ find . -name "*[-_]tests"
./3rdparty/libprocess/src/tests/libprocess-tests
./3rdparty/stout/tests/stout-tests
./src/mesos-tests
```
Thanks,
Michael Park
Re: Review Request 55006: CMake: renamed test binaries to match
autotools.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55006/#review160136
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55004, 55005, 55006]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 23, 2016, 2:22 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55006/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2016, 2:22 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently CMake generates test binaries named `stout_tests`,
> `process_tests` (underscores), and `mesos-tests` (dash).
>
> We should simply follow the naming from autotools and call them
> `stout-tests`, `libprocess-tests`, and `mesos-tests`.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c
> support/windows-build.bat 4d1d8cd6cdcf6acac259b570387923fe385f4790
>
> Diff: https://reviews.apache.org/r/55006/diff/
>
>
> Testing
> -------
>
> `cmake --build . -- -j 6`
> ```
> $ find . -name "*[-_]tests"
> ./3rdparty/libprocess/src/tests/libprocess-tests
> ./3rdparty/stout/tests/stout-tests
> ./src/mesos-tests
> ```
>
> Built on Windows via `support/windows-build.bat`.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55006: CMake: renamed test binaries to match
autotools.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55006/#review160761
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Dec. 22, 2016, 6:22 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55006/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 6:22 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently CMake generates test binaries named `stout_tests`,
> `process_tests` (underscores), and `mesos-tests` (dash).
>
> We should simply follow the naming from autotools and call them
> `stout-tests`, `libprocess-tests`, and `mesos-tests`.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c
> support/windows-build.bat 4d1d8cd6cdcf6acac259b570387923fe385f4790
>
> Diff: https://reviews.apache.org/r/55006/diff/
>
>
> Testing
> -------
>
> `cmake --build . -- -j 6`
> ```
> $ find . -name "*[-_]tests"
> ./3rdparty/libprocess/src/tests/libprocess-tests
> ./3rdparty/stout/tests/stout-tests
> ./src/mesos-tests
> ```
>
> Built on Windows via `support/windows-build.bat`.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55006: CMake: renamed test binaries to match
autotools.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55006/#review160157
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Dec. 23, 2016, 2:22 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55006/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2016, 2:22 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently CMake generates test binaries named `stout_tests`,
> `process_tests` (underscores), and `mesos-tests` (dash).
>
> We should simply follow the naming from autotools and call them
> `stout-tests`, `libprocess-tests`, and `mesos-tests`.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c
> support/windows-build.bat 4d1d8cd6cdcf6acac259b570387923fe385f4790
>
> Diff: https://reviews.apache.org/r/55006/diff/
>
>
> Testing
> -------
>
> `cmake --build . -- -j 6`
> ```
> $ find . -name "*[-_]tests"
> ./3rdparty/libprocess/src/tests/libprocess-tests
> ./3rdparty/stout/tests/stout-tests
> ./src/mesos-tests
> ```
>
> Built on Windows via `support/windows-build.bat`.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55006: CMake: renamed test binaries to match
autotools.
Posted by Michael Park <mp...@apache.org>.
> On Jan. 5, 2017, 4:02 p.m., Alex Clemmer wrote:
> > support/windows-build.bat, line 73
> > <https://reviews.apache.org/r/55006/diff/2/?file=1591510#file1591510line73>
> >
> > Same comment as in #55005. `libprocess` is a misnomer on Windows.
Synced with Alex on Slack: https://mesos.slack.com/archives/windows/p1483776572000827
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55006/#review160651
-----------------------------------------------------------
On Dec. 22, 2016, 6:22 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55006/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 6:22 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently CMake generates test binaries named `stout_tests`,
> `process_tests` (underscores), and `mesos-tests` (dash).
>
> We should simply follow the naming from autotools and call them
> `stout-tests`, `libprocess-tests`, and `mesos-tests`.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c
> support/windows-build.bat 4d1d8cd6cdcf6acac259b570387923fe385f4790
>
> Diff: https://reviews.apache.org/r/55006/diff/
>
>
> Testing
> -------
>
> `cmake --build . -- -j 6`
> ```
> $ find . -name "*[-_]tests"
> ./3rdparty/libprocess/src/tests/libprocess-tests
> ./3rdparty/stout/tests/stout-tests
> ./src/mesos-tests
> ```
>
> Built on Windows via `support/windows-build.bat`.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55006: CMake: renamed test binaries to match
autotools.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55006/#review160651
-----------------------------------------------------------
support/windows-build.bat (line 73)
<https://reviews.apache.org/r/55006/#comment231798>
Same comment as in #55005. `libprocess` is a misnomer on Windows.
- Alex Clemmer
On Dec. 23, 2016, 2:22 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55006/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2016, 2:22 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently CMake generates test binaries named `stout_tests`,
> `process_tests` (underscores), and `mesos-tests` (dash).
>
> We should simply follow the naming from autotools and call them
> `stout-tests`, `libprocess-tests`, and `mesos-tests`.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c
> support/windows-build.bat 4d1d8cd6cdcf6acac259b570387923fe385f4790
>
> Diff: https://reviews.apache.org/r/55006/diff/
>
>
> Testing
> -------
>
> `cmake --build . -- -j 6`
> ```
> $ find . -name "*[-_]tests"
> ./3rdparty/libprocess/src/tests/libprocess-tests
> ./3rdparty/stout/tests/stout-tests
> ./src/mesos-tests
> ```
>
> Built on Windows via `support/windows-build.bat`.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55006: CMake: renamed test binaries to match
autotools.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55006/
-----------------------------------------------------------
(Updated Dec. 22, 2016, 6:22 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Changes
-------
Almost missed the Windows changes.
Repository: mesos
Description (updated)
-------
Currently CMake generates test binaries named `stout_tests`,
`process_tests` (underscores), and `mesos-tests` (dash).
We should simply follow the naming from autotools and call them
`stout-tests`, `libprocess-tests`, and `mesos-tests`.
Diffs (updated)
-----
src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c
support/windows-build.bat 4d1d8cd6cdcf6acac259b570387923fe385f4790
Diff: https://reviews.apache.org/r/55006/diff/
Testing (updated)
-------
`cmake --build . -- -j 6`
```
$ find . -name "*[-_]tests"
./3rdparty/libprocess/src/tests/libprocess-tests
./3rdparty/stout/tests/stout-tests
./src/mesos-tests
```
Built on Windows via `support/windows-build.bat`.
Thanks,
Michael Park