You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by j....@gmail.com on 2016/08/18 02:17:11 UTC
Review Request 51194: HIVE-14566: LLAP IO reads timestamp wrongly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51194/
-----------------------------------------------------------
Review request for hive, Gopal V and Sergey Shelukhin.
Bugs: HIVE-14566
https://issues.apache.org/jira/browse/HIVE-14566
Repository: hive-git
Description
-------
HIVE-14566: LLAP IO reads timestamp wrongly
Diffs
-----
itests/src/test/resources/testconfiguration.properties 2c868074ee8dc51b800b7ecd930abea7793a221a
llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java 94e4750ddc3d4954820f819257f54be0b39e5f08
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcStripeMetadata.java 687458681a12b8345e42a5d8669a6c5d3ebc2119
orc/src/java/org/apache/orc/impl/TreeReaderFactory.java e6fef918b22bf5fac83a4ece5576250476daff27
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java b44da0689f98fe88147f77387e86b50fd3a9b6c4
ql/src/test/results/clientpositive/llap/orc_merge12.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/51194/diff/
Testing
-------
Thanks,
Prasanth_J
Re: Review Request 51194: HIVE-14566: LLAP IO reads timestamp wrongly
Posted by j....@gmail.com.
> On Aug. 18, 2016, 5:55 p.m., Sergey Shelukhin wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java, line 576
> > <https://reviews.apache.org/r/51194/diff/1/?file=1477312#file1477312line576>
> >
> > Is there some way to not have this parameter in every reader? If every time a type needs some parameter, every reader would be affected, it will be out of control soon...
There are 2 other ways
1) In case of TimestampStreamReader, do a cast and call a method that is specific to TimestampStreamReader (somthing like updateTimezone()) for every stripe.
2) Use Java 8's default method that will let us add a default method to interface without having to implement on all classes implementing the interfaces.
Java 8 method is much cleaner IMO. Thoughts?
- Prasanth_J
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51194/#review146106
-----------------------------------------------------------
On Aug. 18, 2016, 2:17 a.m., Prasanth_J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51194/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2016, 2:17 a.m.)
>
>
> Review request for hive, Gopal V and Sergey Shelukhin.
>
>
> Bugs: HIVE-14566
> https://issues.apache.org/jira/browse/HIVE-14566
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14566: LLAP IO reads timestamp wrongly
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 2c868074ee8dc51b800b7ecd930abea7793a221a
> llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java 94e4750ddc3d4954820f819257f54be0b39e5f08
> llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcStripeMetadata.java 687458681a12b8345e42a5d8669a6c5d3ebc2119
> orc/src/java/org/apache/orc/impl/TreeReaderFactory.java e6fef918b22bf5fac83a4ece5576250476daff27
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java b44da0689f98fe88147f77387e86b50fd3a9b6c4
> ql/src/test/results/clientpositive/llap/orc_merge12.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51194/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasanth_J
>
>
Re: Review Request 51194: HIVE-14566: LLAP IO reads timestamp wrongly
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51194/#review146106
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java (line 576)
<https://reviews.apache.org/r/51194/#comment212490>
Is there some way to not have this parameter in every reader? If every time a type needs some parameter, every reader would be affected, it will be out of control soon...
- Sergey Shelukhin
On Aug. 18, 2016, 2:17 a.m., Prasanth_J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51194/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2016, 2:17 a.m.)
>
>
> Review request for hive, Gopal V and Sergey Shelukhin.
>
>
> Bugs: HIVE-14566
> https://issues.apache.org/jira/browse/HIVE-14566
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14566: LLAP IO reads timestamp wrongly
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 2c868074ee8dc51b800b7ecd930abea7793a221a
> llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java 94e4750ddc3d4954820f819257f54be0b39e5f08
> llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcStripeMetadata.java 687458681a12b8345e42a5d8669a6c5d3ebc2119
> orc/src/java/org/apache/orc/impl/TreeReaderFactory.java e6fef918b22bf5fac83a4ece5576250476daff27
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java b44da0689f98fe88147f77387e86b50fd3a9b6c4
> ql/src/test/results/clientpositive/llap/orc_merge12.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51194/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasanth_J
>
>
Re: Review Request 51194: HIVE-14566: LLAP IO reads timestamp wrongly
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51194/
-----------------------------------------------------------
(Updated Aug. 18, 2016, 9:35 p.m.)
Review request for hive, Gopal V and Sergey Shelukhin.
Changes
-------
Addressed Sergey's review comments.
Bugs: HIVE-14566
https://issues.apache.org/jira/browse/HIVE-14566
Repository: hive-git
Description
-------
HIVE-14566: LLAP IO reads timestamp wrongly
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 2c868074ee8dc51b800b7ecd930abea7793a221a
llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java 94e4750ddc3d4954820f819257f54be0b39e5f08
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcStripeMetadata.java 687458681a12b8345e42a5d8669a6c5d3ebc2119
orc/src/java/org/apache/orc/impl/TreeReaderFactory.java e6fef918b22bf5fac83a4ece5576250476daff27
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java b44da0689f98fe88147f77387e86b50fd3a9b6c4
ql/src/test/results/clientpositive/llap/orc_merge12.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/51194/diff/
Testing
-------
Thanks,
Prasanth_J