You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/06/01 18:34:40 UTC
Review Request 48145: GEODE-11: Adding a method to LuceneIndexImpl to
dump indexes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48145/
-----------------------------------------------------------
Review request for geode and xiaojian zhou.
Repository: geode
Description
-------
Adding a method to LuceneIndexImpl to invoke the DumpDirectoryFiles
function and dump all of the index files to disk.
Diffs
-----
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/InternalLuceneIndex.java 951b0f9eb1fcef187dd57e3379a4f1065e12cef4
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 8f2cb10a0dc2d930362473f575042ec25f04c7f2
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java c24cb9d8a8da1b6bb9e9f34ad2c8255f2057cdae
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java 0d7b859c51bc2b701b866f87d9ea496a013e1762
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java 4ae1efec926b495c99097a467ebcfdd3a2de802e
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java 9f02f2b780067e742635e416286969145c8c4862
Diff: https://reviews.apache.org/r/48145/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 48145: GEODE-11: Adding a method to
LuceneIndexImpl to dump indexes
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48145/#review135848
-----------------------------------------------------------
Ship it!
Ship It!
- xiaojian zhou
On June 1, 2016, 6:34 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48145/
> -----------------------------------------------------------
>
> (Updated June 1, 2016, 6:34 p.m.)
>
>
> Review request for geode and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Adding a method to LuceneIndexImpl to invoke the DumpDirectoryFiles
> function and dump all of the index files to disk.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/InternalLuceneIndex.java 951b0f9eb1fcef187dd57e3379a4f1065e12cef4
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 8f2cb10a0dc2d930362473f575042ec25f04c7f2
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java c24cb9d8a8da1b6bb9e9f34ad2c8255f2057cdae
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java 0d7b859c51bc2b701b866f87d9ea496a013e1762
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java 4ae1efec926b495c99097a467ebcfdd3a2de802e
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java 9f02f2b780067e742635e416286969145c8c4862
>
> Diff: https://reviews.apache.org/r/48145/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 48145: GEODE-11: Adding a method to
LuceneIndexImpl to dump indexes
Posted by Dan Smith <ds...@pivotal.io>.
> On June 1, 2016, 8:49 p.m., Jason Huynh wrote:
> > Do the tests clean up the exported files?
Yes. The DiskDirRule will delete the directory after the test completes.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48145/#review135850
-----------------------------------------------------------
On June 1, 2016, 6:34 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48145/
> -----------------------------------------------------------
>
> (Updated June 1, 2016, 6:34 p.m.)
>
>
> Review request for geode and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Adding a method to LuceneIndexImpl to invoke the DumpDirectoryFiles
> function and dump all of the index files to disk.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/InternalLuceneIndex.java 951b0f9eb1fcef187dd57e3379a4f1065e12cef4
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 8f2cb10a0dc2d930362473f575042ec25f04c7f2
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java c24cb9d8a8da1b6bb9e9f34ad2c8255f2057cdae
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java 0d7b859c51bc2b701b866f87d9ea496a013e1762
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java 4ae1efec926b495c99097a467ebcfdd3a2de802e
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java 9f02f2b780067e742635e416286969145c8c4862
>
> Diff: https://reviews.apache.org/r/48145/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 48145: GEODE-11: Adding a method to
LuceneIndexImpl to dump indexes
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48145/#review135850
-----------------------------------------------------------
Ship it!
Do the tests clean up the exported files?
- Jason Huynh
On June 1, 2016, 6:34 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48145/
> -----------------------------------------------------------
>
> (Updated June 1, 2016, 6:34 p.m.)
>
>
> Review request for geode and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Adding a method to LuceneIndexImpl to invoke the DumpDirectoryFiles
> function and dump all of the index files to disk.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/InternalLuceneIndex.java 951b0f9eb1fcef187dd57e3379a4f1065e12cef4
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 8f2cb10a0dc2d930362473f575042ec25f04c7f2
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java c24cb9d8a8da1b6bb9e9f34ad2c8255f2057cdae
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java 0d7b859c51bc2b701b866f87d9ea496a013e1762
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java 4ae1efec926b495c99097a467ebcfdd3a2de802e
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java 9f02f2b780067e742635e416286969145c8c4862
>
> Diff: https://reviews.apache.org/r/48145/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>