You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/21 16:32:12 UTC
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9339: [config] Fixing GET_FEATURE_FLAGS_FUNC example
etr2460 commented on a change in pull request #9339: [config] Fixing GET_FEATURE_FLAGS_FUNC example
URL: https://github.com/apache/incubator-superset/pull/9339#discussion_r396006810
##########
File path: superset/config.py
##########
@@ -302,7 +302,8 @@ def _try_json_readsha(filepath, length): # pylint: disable=unused-argument
#
# from flask import g, request
# def GET_FEATURE_FLAGS_FUNC(feature_flags_dict):
Review comment:
can we add typing to this example too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org