(kudu) branch master updated: KUDU-3788 add trace-viewer into prebuilt components

[al...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 12dab9107 KUDU-3788 add trace-viewer into prebuilt components
12dab9107 is described below

commit 12dab910780628d7c8d59e0ab03bf2fa661d310d
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Sun Aug 9 21:22:35 2026 -0700

    KUDU-3788 add trace-viewer into prebuilt components
    
    This is a follow-up to 30501ee9e33a2799d3eca6816405b4132d3e0d14.
    
    Change-Id: Icc7291be4b96366a8457ca69dc18bb2b6724cf5a
    Reviewed-on: http://gerrit.cloudera.org:8080/24672
    Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
    Tested-by: Alexey Serbin <al...@apache.org>
---
 thirdparty/build-definitions.sh | 6 +++---
 thirdparty/build-thirdparty.sh  | 2 +-
 thirdparty/prebuilt-utils.sh    | 9 +++++++++
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/thirdparty/build-definitions.sh b/thirdparty/build-definitions.sh
index 7918d224e..d195a3066 100644
--- a/thirdparty/build-definitions.sh
+++ b/thirdparty/build-definitions.sh
@@ -949,9 +949,9 @@ build_gcovr() {
 
 # The trace viewer naturally comes as pre-built in its source tarball.
 build_trace_viewer() {
-  echo Installing trace-viewer into the www directory
-  mkdir -p $TP_DIR/../www/
-  cp -a $TRACE_VIEWER_SOURCE/tracing.* $TP_DIR/../www/
+  local dst_dir=$INSTALL_DESTDIR$PREFIX/share/trace-viewer
+  mkdir -p $dst_dir
+  cp -a $TRACE_VIEWER_SOURCE/tracing.* $dst_dir
 }
 
 build_boost() {
diff --git a/thirdparty/build-thirdparty.sh b/thirdparty/build-thirdparty.sh
index c9a3e6418..197bdc9a5 100755
--- a/thirdparty/build-thirdparty.sh
+++ b/thirdparty/build-thirdparty.sh
@@ -286,7 +286,7 @@ if [ -n "$F_COMMON" -o -n "$F_GCOVR" ]; then
 fi
 
 if [ -n "$F_COMMON" -o -n "$F_TRACE_VIEWER" ]; then
-  build_trace_viewer
+  fetch_prebuilt_or_build trace-viewer common
 fi
 
 if [ -n "$F_COMMON" -o -n "$F_CLIENT_ONLY" -o -n "$F_SPARSEHASH" ]; then
diff --git a/thirdparty/prebuilt-utils.sh b/thirdparty/prebuilt-utils.sh
index f10ea3666..f25612dc7 100644
--- a/thirdparty/prebuilt-utils.sh
+++ b/thirdparty/prebuilt-utils.sh
@@ -254,6 +254,15 @@ apply_post_install() {
   if [ "$component" = "llvm" -a "$install_subdir" = "uninstrumented" ]; then
     ln -sfn "$TP_INSTALL_DIR/uninstrumented" "$TP_DIR/clang-toolchain"
   fi
+
+  if [ "$component" = "trace-viewer" ]; then
+    echo Installing trace-viewer into the www directory
+    mkdir -p $TP_DIR/../www/
+    for i in $PREFIX/share/trace-viewer/*; do
+      local fname="$(basename $i)"
+      ln -nsf "$i" "$TP_DIR/../www/$fname"
+    done
+  fi
 }
 
 # Convert a component identifier into the name of its build_* function.