You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2025/06/11 02:14:04 UTC

[I] "Show chart description" causes bottom of x-axis to be cut off in 5.0.0rc3 [superset]

sfirke opened a new issue, #33737:
URL: https://github.com/apache/superset/issues/33737

   ### Bug description
   
   The chart has plenty of room on the dashboard and I can see the x-axis fully when the description is hidden. But when I show it, the x-axis gets blocked:
   
   ![Image](https://github.com/user-attachments/assets/14316aac-31bc-47f9-8ca5-8d9b54d33f48)
   
   Here's the same chart looking good once I hide the description:
   
   ![Image](https://github.com/user-attachments/assets/2aeb7265-fb2b-4f9a-998c-45ce32d01476)
   
   This is a regression from 4.1.2 where this did not occur.
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Firefox
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
   - [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] "Show chart description" causes bottom of x-axis to be cut off heatmap in 5.0.0rc3 [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #33737:
URL: https://github.com/apache/superset/issues/33737#issuecomment-3184709857

   This had a PR merged but may still persist, see my comment here: https://github.com/apache/superset/pull/33843#issuecomment-3184707190


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] "Show chart description" causes bottom of x-axis to be cut off heatmap in 5.0.0rc3 [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #33737: "Show chart description" causes bottom of x-axis to be cut off heatmap in 5.0.0rc3
URL: https://github.com/apache/superset/issues/33737


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] "Show chart description" causes bottom of x-axis to be cut off heatmap in 5.0.0rc3 [superset]

Posted by "ParasProach (via GitHub)" <gi...@apache.org>.
ParasProach commented on issue #33737:
URL: https://github.com/apache/superset/issues/33737#issuecomment-2980604485

   Look for CSS properties like height, max-height, overflow, flex-basis, grid-template-rows, etc., on the chart's parent elements.
   See how these properties change (or don't change correctly) when the description is toggled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] "Show chart description" causes bottom of x-axis to be cut off heatmap in 5.0.0rc3 [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #33737:
URL: https://github.com/apache/superset/issues/33737#issuecomment-3977149557

   Hi @sinanshamsudheen yes to my knowledge this was not fixed. 
   
   I see you sent in a fix, thank you! Could you include before and after screenshots, documenting that the issue still exists on master branch currently and that your fix addresses it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] "Show chart description" causes bottom of x-axis to be cut off heatmap in 5.0.0rc3 [superset]

Posted by "sinanshamsudheen (via GitHub)" <gi...@apache.org>.
sinanshamsudheen commented on issue #33737:
URL: https://github.com/apache/superset/issues/33737#issuecomment-3976297019

   @sfirke hello brother, is this issue still valid? can i fix this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] "Show chart description" causes bottom of x-axis to be cut off heatmap in 5.0.0rc3 [superset]

Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #33737:
URL: https://github.com/apache/superset/issues/33737#issuecomment-2961038492

   <!-- Answer -->
   This appears to be a layout regression introduced after 4.1.2. The chart area in Superset is managed by flex layouts and dynamic resizing hooks, and the chart itself receives its size instructions independently of the description. There’s no evidence that the chart description directly changes the chart’s size or padding, so the x-axis cutoff is likely due to the parent container’s CSS—such as min-height, height, or flex settings—being squeezed when the description is visible. Ensuring that the chart container has enough height after accounting for the description, and avoiding overflow: hidden or insufficient min-height on critical containers, should help prevent the x-axis from being cut off. You may want to experiment with increasing the min-height or adjusting flex settings on the chart’s parent containers to see if that resolves the issue. If you’re using a custom chart plugin, also check its axis/padding logic, as that could contribute to the problem as well.  
   [Reference: Chart and layout code](https://github.com/apache/superset/blob/86e7139245e7444e749b5e8ad1d5167b4df53ce9/superset-frontend/src/components/Chart/Chart.tsx)
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/84e162d5-3b4c-450b-adff-f0fc88110abf?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/84e162d5-3b4c-450b-adff-f0fc88110abf?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/84e162d5-3b4c-450b-adff-f0fc88110abf?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/84e162d5-3b4c-450b-adff-f0fc88110abf?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/84e162d5-3b4c-450b-adff-f0fc88110abf?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/84e162d5-3b4c-450b-adff-f0fc88110abf?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/84e162d5-3b4c-450b-adff-f0fc88110abf?feedback_type=other)</sup>&nbsp;&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[!
 [Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/33737)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] "Show chart description" causes bottom of x-axis to be cut off heatmap in 5.0.0rc3 [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #33737:
URL: https://github.com/apache/superset/issues/33737#issuecomment-2963618916

   Pinging @michael-s-molina even though I don't consider this a 5.0.0 blocker, but a 5.0.1 candidate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] "Show chart description" causes bottom of x-axis to be cut off heatmap in 5.0.0rc3 [superset]

Posted by "sinanshamsudheen (via GitHub)" <gi...@apache.org>.
sinanshamsudheen commented on issue #33737:
URL: https://github.com/apache/superset/issues/33737#issuecomment-3979443958

   > Hi [@sinanshamsudheen](https://github.com/sinanshamsudheen) yes to my knowledge this was not fixed.
   > 
   > I see you sent in a fix, thank you! Could you include before and after screenshots, documenting that the issue still exists on master branch currently and that your fix addresses it?
   
   Sorry for the late replies, i have attached the before and after screenshots to the PR description and also added tests, Thankyou!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org