You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/09 02:02:59 UTC
[GitHub] [shardingsphere] linghengqian opened a new issue, #20936: Documentation for ShardingSphere Agent may can simplify things
linghengqian opened a new issue, #20936:
URL: https://github.com/apache/shardingsphere/issues/20936
## Question
**For English only**, other languages will not accept.
Before asking a question, make sure you have:
- Googled your question.
- Searched open and closed [GitHub issues](https://github.com/apache/shardingsphere/issues).
- Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview).
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot reproduce it on current information, we will **close it**.
- In https://shardingsphere.apache.org/document/5.2.0/en/user-manual/shardingsphere-proxy/observability/#usage-in-shardingsphere-proxy , it mentions that `Configure the absolute path of shardingsphere-agent.jar to the start.sh startup script of shardingsphere proxy.` is required.
- As far as I understand, modifying `start.sh` is very tedious work, and javaagent can be configured in the environment variable `JVM_OPTS`. This should be similar to `-javaagent /xxxxx/agent/shardingsphere-agent.jar`. As mentioned in https://github.com/cloudfoundry/java-buildpack/issues/555#issuecomment-368583041, requires modification `start.sh` complicates things. Refer to https://shardingsphere.apache.org/document/5.2.0/en/user-manual/shardingsphere-proxy/startup/docker/ .
- 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #20936: Documentation for ShardingSphere Agent may can simplify things
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #20936:
URL: https://github.com/apache/shardingsphere/issues/20936#issuecomment-1272468898
- Actually I was talking about https://github.com/apache/shardingsphere/pull/21341 ,🤣 but due to recent changes in master branch, it had a merge conflict not long ago, which has now been resolved.
- Since I don't really want to manage multiple PRs at the same time, I usually don't work on issues in parallel. For this current issue, I will submit a PR shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #20936: Documentation for ShardingSphere Agent may can simplify things
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #20936:
URL: https://github.com/apache/shardingsphere/issues/20936#issuecomment-1250030434
Yes, modifying `start.sh` is a bit fiddly, especially in a container environment.
We should consider a way to quickly control whether to start the agent or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #20936: Documentation for ShardingSphere Agent may can simplify things
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #20936:
URL: https://github.com/apache/shardingsphere/issues/20936#issuecomment-1272431954
> * How should I reopen this issue? I'm just waiting for one of my PRs to be merged...
Hi @linghengqian , which PR is related to this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed issue #20936: Documentation for ShardingSphere Agent may can simplify things
Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #20936: Documentation for ShardingSphere Agent may can simplify things
URL: https://github.com/apache/shardingsphere/issues/20936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #20936: Documentation for ShardingSphere Agent may can simplify things
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #20936:
URL: https://github.com/apache/shardingsphere/issues/20936#issuecomment-1272348469
Hello , this issue has not received a reply for several days.
This issue is supposed to be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] closed issue #20936: Documentation for ShardingSphere Agent may can simplify things
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #20936: Documentation for ShardingSphere Agent may can simplify things
URL: https://github.com/apache/shardingsphere/issues/20936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #20936: Documentation for ShardingSphere Agent may can simplify things
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #20936:
URL: https://github.com/apache/shardingsphere/issues/20936#issuecomment-1272357599
- How should I reopen this issue? I'm just waiting for one of my PRs to be merged...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org