[jira] [Commented] (PARQUET-1951) Allow different strategies to combine key values when merging parquet files

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248721#comment-17248721 ] 

ASF GitHub Bot commented on PARQUET-1951:
-----------------------------------------

satishkotha opened a new pull request #847:
URL: https://github.com/apache/parquet-mr/pull/847


   …merging parquet files
   
   ### Jira
   
   - [ X] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET-1951) issues and references them in the PR title.
   
   ### Tests
   
   - [X ] My PR adds the following unit tests: TestParquetFileWriter#testMergeMetadataWithNoConflictingKeyValues, and testMergeMetadataWithConflictingKeyValues
   
   ### Commits
   
   - [ X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow different strategies to combine key values when merging parquet files
> ---------------------------------------------------------------------------
>
>                 Key: PARQUET-1951
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1951
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cli
>            Reporter: satish
>            Priority: Minor
>
> I work on Apache Hudi project. We store some additional metadata in parquet files (key range in the file, for example).  So the metadata is different in different parquet files that we want to merge these files. 
> Here is what I'm thinking:
> 1) Merge command takes additional command line option: --strategy <StrategyClassName>. 
> 2) We introduce new strategy class in parquet-hadoop to keep the same behavior as today.  
> We can extend that class and provide our custom implementation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)